-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Clean up command switch code #12351
Merged
strega-nil
merged 12 commits into
microsoft:master
from
strega-nil:update-command-flag-code
Jul 16, 2020
Merged
[vcpkg] Clean up command switch code #12351
strega-nil
merged 12 commits into
microsoft:master
from
strega-nil:update-command-flag-code
Jul 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it more similar to the non-command switch code
strega-nil
force-pushed
the
update-command-flag-code
branch
from
July 9, 2020 23:06
580a4a2
to
8bad4c4
Compare
LilyWangL
added
the
category:vcpkg-feature
The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
label
Jul 10, 2020
ras0219
reviewed
Jul 10, 2020
ras0219-msft
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be worth merging from master and performing one final sweep through all commands to ensure every argument has had the --
prefix removed.
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Jul 16, 2020
[vcpkg] Clean up command switch code (microsoft#12351)
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* [vcpkg] Clean up command switch code Make it more similar to the non-command switch code * format * fix the tests * reformat * format * wip * support x- for command options * fix autocomplete * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:vcpkg-feature
The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it more similar to the non-command switch code.