-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[asmjit] Update to the latest commit #12524
Conversation
@ZehMatt
Since we have added Supports:!uwp in CONTROL file, there is no need to add these failed info. |
Done |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @ZehMatt |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Polyhook2 uses a now deprecated function. I can not update Polyhook2 before updating AsmJit and I can not update AsmJit before updating Polyhook2, how would I go about this problem? |
Can you update them at the same time in this PR? |
The author of Polyhook2 updated to the most recent asmjit commit, I've included it now in this PR. |
Hi @ZehMatt Thanks for this PR. |
The asmjit port I use heavily, Polyhook2 not so much. So yes 🤔? |
Hi i'm the author of polyhook, the latest asmjit changes have been tested by me and work fine with the latest polyhook now that i've upgraded. @ZehMatt i'm not sure what the purpose of ci.baseline.txt is for, but i think we actually want polyhook in there? To update the polyhook port please simply replace the REF and SHA256 in the portfile with:
Then additionally in the CONTROL set the version to Version: 2020-08-03. Do not change any other values in the polyhook2 port, everything else will work fine once you upgrade the version and commit REF. Since this is your PR could you do that? |
I've already updated Polyhook2, and I was specifically asked to remove the lines out of ci.baseline.txt, it seems to be deprecated. |
Thanks for your so detailed information about For ci.baseline.txt, it is used to keep CI work fine. Since we should make sure all checks pass on CI(show green mark) before every PR is merged. So if some ports don't support any specific triplets and there is no description for the unsupported triplet in Thanks for this PR. It seems that all checks have passed on CI. |
Updates the asmjit port to the latest commit in the master branch which contains some bug fixes.