Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] add env var VCPKG_OVERLAY_TRIPLETS #12790

Merged
merged 11 commits into from
Sep 28, 2020
Merged

[vcpkg] add env var VCPKG_OVERLAY_TRIPLETS #12790

merged 11 commits into from
Sep 28, 2020

Conversation

Neumann-A
Copy link
Contributor

logical continuation of #12640

@JackBoosY JackBoosY added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Aug 7, 2020
ras0219
ras0219 approved these changes Aug 10, 2020
View reviewed changes
docs/users/config-environment.md Outdated Show resolved Hide resolved
@Neumann-A @ras0219
Apply CR
d783ae2 
Co-authored-by: ras0219 <533828+ras0219@users.noreply.github.com>
strega-nil
strega-nil approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one change :)

toolsrc/src/vcpkg/base/strings.cpp Outdated Show resolved Hide resolved
@Neumann-A @strega-nil
Apply CR2
8ffe347 
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

@BillyONeal Could you please look at the failure logs on the pipeline test?

@Neumann-A Neumann-A mentioned this pull request Aug 18, 2020
Closed
@JackBoosY
Copy link
Contributor 

A suitable version of git was not found (required v2.7.4) and unable to automatically download a portable one. Please install a newer version of git.

@oskaritimperi
Copy link
Contributor

Is this feature planned to land at master at some point?

@ras0219-msft ras0219-msft merged commit 0c1c437 into microsoft:master Sep 28, 2020
@ras0219-msft
Copy link
Contributor

Thanks!

@Neumann-A Neumann-A deleted the add_env_overlay_triplets branch September 28, 2020 15:48
@sschnug sschnug mentioned this pull request Sep 28, 2020
Closed
strega-nil added a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@Neumann-A @ras0219
@strega-nil @BillyONeal @ras0219-msft
[vcpkg] add env var VCPKG_OVERLAY_TRIPLETS (microsoft#12790)
cfd06bf 
* [vcpkg] add env var VCPKG_OVERLAY_TRIPLETS

* shorten way to complicated doc

* run clang format

* Apply CR

Co-authored-by: ras0219 <533828+ras0219@users.noreply.github.com>

* Apply CR2

Co-authored-by: nicole mazzuca <mazzucan@outlook.com>

Co-authored-by: ras0219 <533828+ras0219@users.noreply.github.com>
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219 ras0219 ras0219 approved these changes

@strega-nil strega-nil strega-nil approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Neumann-A @strega-nil @JackBoosY @oskaritimperi @ras0219-msft @ras0219 @PhoebeHui @BillyONeal