[boost] Remove invalid identifier !v120 #13387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoebeHui
added
category:port-bug
|
@ManuelKugelmann Looks like you're going to need to plumb that around if you want to use it in that way. |
|
@BillyONeal @PhoebeHui @JackBoosY Seems like the identifier stuff would benefit from a little work - to me the current fixed list seems a bit too hard coded for essentially arbitrary string input. As a first step missing overrides should probably be treated as "false". A informational message could make the user aware of that. Will think a bit about it and do another PR ... Any suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13373
This issue involved by PR #10645, the identifier v120 is invalid, remove it for unblocking boost, and keep others changes in PR #10645 for futher fix from contributor.
See valid identifier in https://github.com/microsoft/vcpkg/blob/master/toolsrc/src/vcpkg/platform-expression.cpp#L37