Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the latest g++-10 version if exists #13644

Merged

Conversation

cngzhnp
Copy link
Contributor

@cngzhnp cngzhnp commented Sep 21, 2020

The latest g++/gcc version(10.0) has been already released for different Linux distros, so it would be great to use it if exists on the environment.

@JackBoosY JackBoosY self-assigned this Sep 22, 2020
@JackBoosY JackBoosY added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Sep 22, 2020
@josef-dijon
Copy link

Homebrew installs GCC 10.2.0 by default, so following the README quickstart for Unix on MacOS, bootstrap-vcpkg.sh fails.

This PR fixed my issue of not being able to build vcpkg on Majave 10.14.6 with Xcode 10.2.1 and clang 10.0.1.

Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for the PR!

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 25, 2020
@JackBoosY
Copy link
Contributor

Blocked by #13722.

@ras0219-msft ras0219-msft merged commit 8fcd02d into microsoft:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants