Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geogram] build geogram dynamic if crt linkage dynamic #13719

Merged
merged 3 commits into from
Oct 6, 2020
Merged

[geogram] build geogram dynamic if crt linkage dynamic #13719

merged 3 commits into from
Oct 6, 2020

Conversation

xandox
Copy link
Contributor

@xandox xandox commented Sep 24, 2020

Fix installation for triplet x64-windows-static-md

  • What does your PR fix? Fixes #
    profile.cmake

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    now support x64-windows-static-md triplet

  • Does your PR follow the maintainer guide?
    I hope

fix settings for switch to dynamic linkage
@LilyWangL LilyWangL changed the title build geogram dynamic if crt linkage dynamic [geogram] build geogram dynamic if crt linkage dynamic Sep 25, 2020
@LilyWangL LilyWangL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 25, 2020
@LilyWangL
Copy link
Contributor

Blocked by #13722.

@ras0219-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Sep 30, 2020
@xandox
Copy link
Contributor Author

xandox commented Oct 2, 2020

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 13719 in repo microsoft/vcpkg

@xandox
Copy link
Contributor Author

xandox commented Oct 2, 2020

@LilyWangL help! :)
How to rerun canceled checks?

@dan-shaw
Copy link
Contributor

dan-shaw commented Oct 6, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@BillyONeal BillyONeal merged commit 7f0ea80 into microsoft:master Oct 6, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants