[etcd-cpp-apiv3] Add etcd-cpp-vpiv3 port. #15373
Conversation
Signed-off-by: Tao He <sighingnow@gmail.com>
Signed-off-by: Tao He <sighingnow@gmail.com>
JackBoosY
added
the
category:new-port
| @@ -0,0 +1,6 @@ | |||
| Source: etcd-cpp-apiv3 | |||
| Version: etcd-cpp-apiv3-7e280ec | |||
There was a problem hiding this comment.
| Version: etcd-cpp-apiv3-7e280ec | |
| Version: 2020-12-30 |
We should use the date that you accept the commits if there is no released version.
Please see https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/control-files.md#version
| Build-Depends: boost-system, boost-thread, boost-locale, boost-random, | ||
| cpprestsdk, grpc, openssl, protobuf |
There was a problem hiding this comment.
| Build-Depends: boost-system, boost-thread, boost-locale, boost-random, | |
| cpprestsdk, grpc, openssl, protobuf | |
| Build-Depends: boost-system, boost-thread, boost-locale, boost-random, cpprestsdk, grpc, openssl, protobuf |
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO etcd-cpp-apiv3/etcd-cpp-apiv3 | ||
| REF 7e280ec8a49aaf26976d72a4080f2e2c6756f2b7 |
There was a problem hiding this comment.
Why do you not use the latest commit here?
| vcpkg_copy_pdbs() | ||
|
|
||
| # Handle copyright | ||
| file(INSTALL ${SOURCE_PATH}/LICENSE.txt DESTINATION ${CURRENT_PACKAGES_DIR}/share/etcd-cpp-apiv3 RENAME copyright) |
There was a problem hiding this comment.
| file(INSTALL ${SOURCE_PATH}/LICENSE.txt DESTINATION ${CURRENT_PACKAGES_DIR}/share/etcd-cpp-apiv3 RENAME copyright) | |
| file(INSTALL ${SOURCE_PATH}/LICENSE.txt DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright) |
| @@ -260,6 +260,7 @@ epsilon:arm-uwp=fail | |||
| epsilon:x64-linux=fail | |||
| epsilon:x64-osx=fail | |||
| epsilon:x64-uwp=fail | |||
| etcd-cpp-apiv3:arm64-windows=fail | |||
There was a problem hiding this comment.
Does this port not support arm64?
| -DBUILD_ETCD_TESTS=OFF | ||
| ) | ||
| set(VCPKG_POLICY_DLLS_WITHOUT_LIBS enabled) | ||
| set(VCPKG_POLICY_DLLS_WITHOUT_EXPORTS enabled) |
There was a problem hiding this comment.
Why do you need to add these two polices?
|
Hi @sighingnow Thanks for adding this port. I noticed there are no any files installed in the list. Could you please help confirm if there is something wrong? |
|
Could you please resolve the conflicts? |
Will fixes that ASAP. |
|
Hi @sighingnow Is work still being done this PR? |
|
I temporarily close this issue and will reopen when I back to that project. |
|
Replaced by: #29363 |
Add the etcd-cpp-apiv3 library.
Any platforms/triplets that cpprestsdk and grpc are supported.
Yes.