Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libsamplerate] Upgrade to 0.2.0 #15797

Merged
merged 8 commits into from
Jan 22, 2021
Merged

Conversation

evpobr
Copy link
Contributor

@evpobr evpobr commented Jan 21, 2021

Upgrade libsamplerate port to 0.2.0

  • Upgrade to 0.2.0
  • Use mainstream CMake project
  • Remove obsolete patch
  • Add versions to port_versions/
  • Updated project URL

@Be-ing
Copy link
Contributor

Be-ing commented Jan 21, 2021

I was about to open a PR for this and saw yours. 😆 Thanks for taking care of this.

port_versions/baseline.json Outdated Show resolved Hide resolved
@Be-ing
Copy link
Contributor

Be-ing commented Jan 21, 2021

This fixes the macOS build which was broken with 0.1.9.

@Be-ing
Copy link
Contributor

Be-ing commented Jan 21, 2021

ping @NancyLi1013

@Be-ing
Copy link
Contributor

Be-ing commented Jan 21, 2021

CI builds failed:

Error: Couldn't find explicitly specified baseline `"16002d9c2318dec4c69e02d9af8c0e11dca0d4c6"` in the baseline file, and there was no baseline at that commit or the commit didn't exist.
Error: while checking out baseline '16002d9c2318dec4c69e02d9af8c0e11dca0d4c6:versions/baseline.json':
fatal: Path 'versions/baseline.json' exists on disk, but not in '16002d9c2318dec4c69e02d9af8c0e11dca0d4c6'.

@evpobr
Copy link
Contributor Author

evpobr commented Jan 22, 2021

One directory was renamed in upstream and pull request is now broken.

@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Jan 22, 2021
@NancyLi1013
Copy link
Contributor

@Be-ing and @evpobr

The current CI failures are caused by our changes.

Don't worry about this. You just need to merge master to this PR.

@evpobr
Copy link
Contributor Author

evpobr commented Jan 22, 2021

@Be-ing and @evpobr

The current CI failures are caused by our changes.

Don't worry about this. You just need to merge master to this PR.

@NancyLi1013 , done.

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 22, 2021
@JonLiu1993 JonLiu1993 marked this pull request as draft January 22, 2021 08:07
ports/libsamplerate/portfile.cmake Outdated Show resolved Hide resolved
ports/libsamplerate/portfile.cmake Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jan 22, 2021
@JonLiu1993 JonLiu1993 marked this pull request as ready for review January 22, 2021 08:20
ports/libsamplerate/portfile.cmake Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 22, 2021
@JonLiu1993
Copy link
Member

@evpobr ,Please merge the master and run the command vcpkg x-add-version and resubmit

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@JonLiu1993 JonLiu1993 removed the info:reviewed Pull Request changes follow basic guidelines label Jan 22, 2021
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 22, 2021
@evpobr
Copy link
Contributor Author

evpobr commented Jan 22, 2021

@evpobr ,Please merge the master and run the command vcpkg x-add-version and resubmit

PS D:\source\repos\vcpkg> vcpkg x-add-version  
Error: Use option `--all` to update version files for all ports at once.
PS D:\source\repos\vcpkg> vcpkg x-add-version --all

Nothing changed.

@dan-shaw dan-shaw merged commit 34a9432 into microsoft:master Jan 22, 2021
@Be-ing
Copy link
Contributor

Be-ing commented Jan 22, 2021

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants