Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kf5codecs] new port #16561

Merged
merged 10 commits into from
May 28, 2021
Merged

[kf5codecs] new port #16561

merged 10 commits into from
May 28, 2021

Conversation

wrobelda
Copy link
Contributor

@wrobelda wrobelda commented Mar 5, 2021

Describe the pull request
Adds new kf5codecs port.

Which triplets are supported/not supported? Have you updated the CI baseline?
All official should be supported.

Does your PR follow the maintainer guide?
Yes

@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 8, 2021
ports/kf5codecs/vcpkg.json Outdated Show resolved Hide resolved
versions/k-/kf5codecs.json Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 16, 2021

Seems you need to rebase this PR now, many changes were brought in this PR. Or you can open a new pull request to adding this port.

@wrobelda
Copy link
Contributor Author

wrobelda commented May 22, 2021

@NancyLi1013 should be ready. The libsigcpp is failing for each triplet and should be unrelated.

@wrobelda wrobelda marked this pull request as ready for review May 22, 2021 21:49
@NancyLi1013
Copy link
Contributor

Seems there is something wrong with the patch file disable_tests_enable_static_build.patch. We might need to patch it in another way.

Starting package 112/222: libsigcpp:x86-windows
Building package libsigcpp[core]:x86-windows...
-- Downloading https://github.com/libsigcplusplus/libsigcplusplus/archive/7e20b36bddab74faed39aa3768d07fd372fce596.tar.gz -> libsigcplusplus-libsigcplusplus-7e20b36bddab74faed39aa3768d07fd372fce596.tar.gz...
CMake Error at scripts/cmake/vcpkg_extract_source_archive_ex.cmake:100 (file):
  file SHA512 failed to read file
  "C:/a/1/s/ports/libsigcpp/disable_tests_enable_static_build.patch": No such
  file or directory
Call Stack (most recent call first):
  scripts/cmake/vcpkg_from_github.cmake:154 (vcpkg_extract_source_archive_ex)
  ports/libsigcpp/portfile.cmake:1 (vcpkg_from_github)
  scripts/ports.cmake:141 (include)

ports/kf5codecs/portfile.cmake Outdated Show resolved Hide resolved
ports/kf5codecs/portfile.cmake Outdated Show resolved Hide resolved
ports/kf5codecs/portfile.cmake Outdated Show resolved Hide resolved
ports/kf5codecs/portfile.cmake Outdated Show resolved Hide resolved
ports/kf5codecs/vcpkg.json Show resolved Hide resolved
@wrobelda
Copy link
Contributor Author

@NancyLi1013 addressed all of the issues and rebased. libsigcpp still fails, though.

@NancyLi1013
Copy link
Contributor

Can you merge master to this PR? @wrobelda It seems that there is no disable_tests_enable_static_build.patch on your branch.

@NancyLi1013
Copy link
Contributor

You delated this patch files in this PR.
image

@wrobelda
Copy link
Contributor Author

wrobelda commented May 26, 2021

You delated this patch files in this PR.

Yes, I literally just found out about this 🤦🏻‍♂️. No clue how that happened. Fixing.

EDIT: Fixed.

ports/libgpg-error/runtime.patch Outdated Show resolved Hide resolved
@wrobelda wrobelda force-pushed the kf5codecs branch 3 times, most recently from c246a17 to da58f47 Compare May 26, 2021 03:23
@NancyLi1013
Copy link
Contributor

LGTM now, except for the problem caused by libtasn1. Will be fixed in #18116.

@wrobelda
Copy link
Contributor Author

@NancyLi1013 I rebased to pick-up a fix for #18116, but CI/CD seems stuck.

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

@NancyLi1013 I rebased to pick-up a fix for #18116, but CI/CD seems stuck.

Let's wait for the new CI test result.

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label May 28, 2021
@strega-nil-ms
Copy link
Contributor

Awesome, thanks again @wrobelda :)

@strega-nil-ms strega-nil-ms merged commit 1c4fb01 into microsoft:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants