Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline][libtasn1] Fix static build #18116

Merged
merged 7 commits into from
May 26, 2021
Merged

[vcpkg baseline][libtasn1] Fix static build #18116

merged 7 commits into from
May 26, 2021

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented May 26, 2021 •
edited
Loading

Fix static build on Windows:

   Creating library asn1Parser.lib and object asn1Parser.exp
asn1Parser.obj : error LNK2019: unresolved external symbol __imp_asn1_parser2tree referenced in function main
asn1Parser.obj : error LNK2019: unresolved external symbol __imp_asn1_parser2array referenced in function main
asn1Parser.obj : error LNK2019: unresolved external symbol __imp_asn1_delete_structure referenced in function main
asn1Parser.obj : error LNK2019: unresolved external symbol __imp_asn1_strerror referenced in function main
asn1Parser.exe : fatal error LNK1120: 4 unresolved externals
   Creating library asn1Coding.lib and object asn1Coding.exp
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_parser2tree referenced in function main
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_print_structure referenced in function main
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_create_element referenced in function main
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_delete_structure referenced in function main
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_write_value referenced in function main
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_der_coding referenced in function main
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_strerror referenced in function main
...

Add ASN1_STATIC to C_FLAGS / CXX_FLAGS because this macro does not exist in the source configuration file.

Related: #16953

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels May 26, 2021
@JackBoosY JackBoosY mentioned this pull request May 26, 2021
Closed
@JackBoosY JackBoosY mentioned this pull request May 26, 2021
Merged
This was referenced May 26, 2021
Merged
Merged
@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels May 26, 2021
JackBoosY
JackBoosY commented May 26, 2021
View reviewed changes
versions/l-/libtasn1.json Outdated Show resolved Hide resolved
@JackBoosY JackBoosY mentioned this pull request May 26, 2021
Merged
PhoebeHui
PhoebeHui approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 26, 2021
@JackBoosY JackBoosY mentioned this pull request May 26, 2021
Merged
@JackBoosY
Copy link
Contributor Author

Ping @strega-nil-ms for merge this PR first.

JackBoosY
JackBoosY commented May 26, 2021
View reviewed changes
versions/l-/libtasn1.json Outdated Show resolved Hide resolved
@JackBoosY JackBoosY mentioned this pull request May 26, 2021
Merged
@strega-nil-ms strega-nil-ms merged commit f2f9f79 into microsoft:master May 26, 2021
@wrobelda wrobelda mentioned this pull request May 27, 2021
Open
@JackBoosY JackBoosY deleted the dev/jack/fix-baseline-20210526 branch May 27, 2021 01:55
@JackBoosY JackBoosY mentioned this pull request Jun 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackBoosY @dg0yt @PhoebeHui @strega-nil-ms