Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[luasec] new port #17957

Merged
merged 3 commits into from
Jun 9, 2021
Merged

[luasec] new port #17957

merged 3 commits into from
Jun 9, 2021

Conversation

TheCycoONE
Copy link
Contributor

@TheCycoONE TheCycoONE commented May 16, 2021 •
edited
Loading

Adds luasec, a lua library for networking over TLS.

https://github.com/brunoos/luasec/

  • Which triplets are supported/not supported? Have you updated the CI baseline?

all, No

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@TheCycoONE TheCycoONE changed the title Add vcpkg port for luasec [luasec] new port May 16, 2021
@TheCycoONE TheCycoONE marked this pull request as ready for review May 16, 2021 02:04
@TheCycoONE TheCycoONE marked this pull request as draft May 16, 2021 02:16
@TheCycoONE TheCycoONE marked this pull request as ready for review May 16, 2021 02:36
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 18, 2021
@JonLiu1993
Copy link
Member

@ras0219,Could you help review this pr?

PhoebeHui
PhoebeHui reviewed May 25, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LUASEC_VERSION looks not used.

ports/luasec/portfile.cmake Outdated Show resolved Hide resolved
JackBoosY
JackBoosY suggested changes May 25, 2021
View reviewed changes
ports/luasec/CMakeLists.txt Outdated Show resolved Hide resolved
ports/luasec/portfile.cmake Show resolved Hide resolved
@TheCycoONE
Copy link
Contributor Author

Changed as suggested and removed the prefix from the so library. I'm still not clear on how we'd want to handle a possible name collision. I think the same approach should be applied to luasocket, lpeg, luafilesystem - whatever we pick.

@TheCycoONE TheCycoONE marked this pull request as draft May 26, 2021 00:40
@TheCycoONE
Copy link
Contributor Author

@JackBoosY any idea why I'm getting those errors "REGRESSION: libtasn1:x64-windows-static. If expected, add libtasn1:x64-windows-static=fail to .\scripts\ci.baseline.txt." - seems to happen every time, and I'm not sure what it has to do with my changes.

@JackBoosY
Copy link
Contributor

Waiting for #18116 merge.

@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels May 26, 2021
@JackBoosY
Copy link
Contributor

Ready for review now?

@TheCycoONE TheCycoONE marked this pull request as ready for review May 28, 2021 02:46
@TheCycoONE
Copy link
Contributor Author

Yes, thank you.

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 1, 2021
@strega-nil-ms
Copy link
Contributor

Thanks @TheCycoONE :)

@strega-nil-ms strega-nil-ms merged commit 17378cf into microsoft:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219 ras0219 ras0219 left review comments

@PhoebeHui PhoebeHui PhoebeHui left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TheCycoONE @JonLiu1993 @JackBoosY @strega-nil-ms @ras0219 @PhoebeHui