[protobuf] Update to 3.21.2 #24400
Merged
[protobuf] Update to 3.21.2 #24400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2022 03:38
LilyWangLL
added
info:internal
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
added 2 commits
April 26, 2022 00:14
raghavthind2005
previously approved these changes
Apr 26, 2022
…LilyWang/issue24305
|
Not sure if this is really the right place to ask but I'd love to see a newer version of protobuf added to vcpkg. The current version (3.19.4) won't compile with Clang on Windows. protocolbuffers/protobuf#9680 |
|
+1, is there an ETA for when this fix can be landed. Thanks! |
LilyWangLL
dismissed stale reviews from github-actions and raghavthind2005
via
63576ff
added 3 commits
June 28, 2022 01:58
…LL/vcpkg into dev/LilyWang/issue24305
added 2 commits
June 30, 2022 23:35
JackBoosY
previously approved these changes
Jul 1, 2022
JackBoosY
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
stringtostd:string, this change can fix the build error ofignition-msgs*, the related upstream PR: Add std:: to strings in Generator.cc/hh gazebosim/gz-msgs#129gazeboto fix build error.