Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protobuf] Update to 3.21.2 #24400

Merged
merged 16 commits into from
Jul 7, 2022

Conversation

LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL commented Apr 25, 2022

Describe the pull request

  • What does your PR fix?

  1. Fixes [protobuf] update to 3.20.1 #24305, update protobuf to version 3.20.1. Feature has been test pass on x86-windows.
  2. Changing string to std:string, this change can fix the build error of ignition-msgs*, the related upstream PR: Add std:: to strings in Generator.cc/hh gazebosim/gz-msgs#129
  3. Sync up the upstream changes of gazebo to fix build error.

@LilyWangLL LilyWangLL added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Apr 25, 2022
github-actions[bot]
github-actions bot previously approved these changes May 24, 2022
@nickanthony-dgl
Copy link

Not sure if this is really the right place to ask but I'd love to see a newer version of protobuf added to vcpkg. The current version (3.19.4) won't compile with Clang on Windows. protocolbuffers/protobuf#9680

@k-ye
Copy link

k-ye commented Jun 24, 2022

+1, is there an ETA for when this fix can be landed. Thanks!

@LilyWangLL LilyWangLL changed the title [protobuf] Update to 3.20.1 [protobuf] Update to 3.21.2 Jun 28, 2022
github-actions[bot]
github-actions bot previously approved these changes Jun 28, 2022
github-actions[bot]
github-actions bot previously approved these changes Jun 28, 2022
github-actions[bot]
github-actions bot previously approved these changes Jun 28, 2022
@LilyWangLL LilyWangLL marked this pull request as ready for review June 28, 2022 09:15
github-actions[bot]
github-actions bot previously approved these changes Jul 1, 2022
JackBoosY
JackBoosY previously approved these changes Jul 1, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jul 5, 2022
@LilyWangLL LilyWangLL requested a review from JackBoosY July 7, 2022 01:43
@vicroms vicroms merged commit 087ef91 into microsoft:master Jul 7, 2022
@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue24305 branch July 12, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[protobuf] update to 3.20.1
6 participants