Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[directx-dxc, directxtk12] update port for July 2022 release and native ARM64 support #25827

Merged
merged 5 commits into from
Jul 25, 2022

Conversation

walbourn
Copy link
Member

@walbourn walbourn commented Jul 17, 2022

This updates the directx-dxc port for the July 2022 release of the DirectX DXC Compiler on GitHub. This release adds arm64 native support in addition to x64.

This includes an upstream hot-fix to directxtk12

github-actions[bot]
github-actions bot previously approved these changes Jul 17, 2022
@walbourn
Copy link
Member Author

I don't understand why the arm64-windows failed. The vcpkg.json for directxtk12 lists host: true for directx-dxc, so it should have used the x64-windows version of directx-dxc.

    vcpkg-cmake:x64-windows: SUCCEEDED: 4.693 ms
    vcpkg-cmake-config:x64-windows: SUCCEEDED: 2.794 ms
    directx-headers:arm64-windows: SUCCEEDED: 14.88 ms
    directx-dxc:arm64-windows: SUCCEEDED: 4.415 s
    directx-dxc:x64-windows: SUCCEEDED: 50.44 ms
    directxmath:arm64-windows: SUCCEEDED: 7.456 ms
    directxtk12:arm64-windows: BUILD_FAILED: 2.642 s

Can someone look at the logs more to see why it failed? Locally it builds fine using:

The following packages will be built and installed:
  * directx-dxc[core]:x64-windows -> 2022-07-13
  * directx-headers[core]:arm64-windows -> 1.602.0
  * directxmath[core]:arm64-windows -> 2022-05-18
    directxtk12[core,xaudio2-9]:arm64-windows -> 2022-06-15
  * vcpkg-cmake[core]:x64-windows -> 2022-07-02
  * vcpkg-cmake-config[core]:x64-windows -> 2022-02-06#1

@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Jul 18, 2022
@Cheney-W
Copy link
Contributor

Because directx-dxc has been modified, all its supported triplets will be tested in CI, which is expected. And directx-dxc:x64-windows being installed is proof that host:true is working.
You can understand it this way, there are two ports that need to be tested:

  1. directx-dxc (All supported trilpets are installed)
  2. directxtk12 (Because it depends on directx-dxc, it will be tested. While installing it, host true worked, so directx-dxc:x64-windows was installed)

Please use following command to reproduce the failure in arm64-windows:
.\vcpkg.exe install directx-dxc:arm64-windows directxtk12:arm64-windows

Failure log:
install-arm64-windows-dbg-err.log
This version of D:\installed\arm64-windows\tools\directx-dxc\dxc.exe is not compatible with the version of Windows you're running. Check your computer's system information and then contact the software publisher.

@Cheney-W
Copy link
Contributor

This issue should be a bug in directxtk12 https://github.com/microsoft/DirectXTK12/blob/5062aad41e6d701292fa1bad996f6436ee023fd8/CMakeLists.txt#L199

Please add NO_DEFAULT_PATH into the find_program function, I have tested it in my side and .\vcpkg.exe install directx-dxc:arm64-windows directxtk12:arm64-windows run successfully.

@walbourn
Copy link
Member Author

Working a fix for upstream.

@Cheney-W
Copy link
Contributor

I saw you have update the upstream, are we currently waiting for the new DirectXTK12 to be released or giving a patch to the DirectXTK12 on vcpkg?

@walbourn
Copy link
Member Author

I am trying to resolve some MinGW issues in directxk12 related to updating the DirectX headers port as well.

github-actions[bot]
github-actions bot previously approved these changes Jul 23, 2022
@walbourn walbourn changed the title [directx-dxc] update port for July 2022 release and native ARM64 support [directx-dxc, directxtk12] update port for July 2022 release and native ARM64 support Jul 23, 2022
@walbourn
Copy link
Member Author

walbourn commented Jul 24, 2022

@Cheney-W Have an upstream fix in place, and it builds now.

Once this PR is completed, I'll do a port update for directx-headers and the associated MinGW support changes for directxtk12 and directxtex.

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jul 25, 2022
@BillyONeal BillyONeal merged commit cad7402 into microsoft:master Jul 25, 2022
@BillyONeal
Copy link
Member

Thanks :)

@walbourn walbourn deleted the directxdxcjul2022 branch July 25, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants