Update vcpkg-tool to 2023-02-16. #29664

BillyONeal · 2023-02-15T03:22:19Z

https://github.com/microsoft/vcpkg-tool/releases/tag/2023-02-16

autoantwort · 2023-02-15T10:15:07Z

You probably also have to merge microsoft/vcpkg-tool#906 to get a green ci.

dg0yt · 2023-02-17T07:32:30Z

The new CI regressions are expected, due to unblocking of port builds by no longer pulling in unsupported features via unsupported features and ports. This is the work which started with #28619, lead to microsoft/vcpkg-tool#846, but was ignored in the course of merging microsoft/vcpkg-tool#856 which unblocked even more ports.

As a quick mitigation, I suggest to compare with the CI build before this PR, and then add expected failures to the CI baseline.

walbourn · 2023-02-17T08:06:26Z

Verified this update resolves all the issues with the new xbox supports term.

…CPKG_POLICY_SKIP_DUMPBIN_CHECKS now that checking for msvc no longer requires dumpbin.

BillyONeal · 2023-02-18T03:48:30Z

The new CI regressions are expected, due to unblocking of port builds by no longer pulling in unsupported features via unsupported features and ports. This is the work which started with #28619, lead to microsoft/vcpkg-tool#846, but was ignored in the course of merging microsoft/vcpkg-tool#856 which unblocked even more ports.

Yep! Also the dumpbin dependency removal resulted in post-build checks being more accurate in a few places.

As a quick mitigation, I suggest to compare with the CI build before this PR, and then add expected failures to the CI baseline.

I'm verifying for each case.

This never worked on Windows but was guarded before by failed dependencies on arm.

…rts.ps1. microsoft#29540 and microsoft#29481 forgot to rerun generate-ports.ps1. Note that the default port-version was bumped because most everything depends on boost-build that change touched.

…rather than pegtl, if that port happened to get installed first.

BillyONeal · 2023-02-18T06:59:25Z

Saving this screenshot demonstrating why I changed vtk:

Upstream has: ``` // in buildtrees\harfbuzz\src\6.0.0-21fda9578f.clean\src\hb-ft.h #if defined(WINAPI_FAMILY) && (WINAPI_FAMILY != WINAPI_FAMILY_DESKTOP_APP) #define generic GenericFromFreeTypeLibrary #endif ``` resulting in ``` ../src/6.0.0-21fda9578f.clean/src/hb-ft.cc(985): error C2039: 'generic': is not a member of 'FT_FaceRec_' C:\Dev\vcpkg\installed\x64-uwp\include\freetype/freetype.h(1077): note: see declaration of 'FT_FaceRec_' ../src/6.0.0-21fda9578f.clean/src/hb-ft.cc(1010): error C2039: 'generic': is not a member of 'FT_FaceRec_' C:\Dev\vcpkg\installed\x64-uwp\include\freetype/freetype.h(1077): note: see declaration of 'FT_FaceRec_' ``` so this problem is an upstream issue with not supporting non-desktop Windows.

BillyONeal · 2023-02-18T07:37:23Z

Similarly, what changed for nghttp2:

``` warning: The App Container bit must be set for Windows Store apps. The following DLLs do not have the App Container bit set: D:\packages\vcpkg-gfortran_x64-uwp\debug\bin\libgcc_s_seh-1.dll D:\packages\vcpkg-gfortran_x64-uwp\debug\bin\libgfortran-5.dll D:\packages\vcpkg-gfortran_x64-uwp\debug\bin\libquadmath-0.dll D:\packages\vcpkg-gfortran_x64-uwp\debug\bin\libwinpthread-1.dll D:\packages\vcpkg-gfortran_x64-uwp\bin\libgcc_s_seh-1.dll D:\packages\vcpkg-gfortran_x64-uwp\bin\libgfortran-5.dll D:\packages\vcpkg-gfortran_x64-uwp\bin\libquadmath-0.dll D:\packages\vcpkg-gfortran_x64-uwp\bin\libwinpthread-1.dll ``` This previously succeeded in CI but the resulting program could not be distributed.

BillyONeal · 2023-02-18T07:59:48Z

[vcpkg-gfortran] Also not supported on UWP.

warning: The App Container bit must be set for Windows Store apps. The following DLLs do not have the App Container bit set:

    D:\packages\vcpkg-gfortran_x64-uwp\debug\bin\libgcc_s_seh-1.dll
    D:\packages\vcpkg-gfortran_x64-uwp\debug\bin\libgfortran-5.dll
    D:\packages\vcpkg-gfortran_x64-uwp\debug\bin\libquadmath-0.dll
    D:\packages\vcpkg-gfortran_x64-uwp\debug\bin\libwinpthread-1.dll
    D:\packages\vcpkg-gfortran_x64-uwp\bin\libgcc_s_seh-1.dll
    D:\packages\vcpkg-gfortran_x64-uwp\bin\libgfortran-5.dll
    D:\packages\vcpkg-gfortran_x64-uwp\bin\libquadmath-0.dll
    D:\packages\vcpkg-gfortran_x64-uwp\bin\libwinpthread-1.dll

This previously succeeded in CI but the resulting program could not be distributed because it would fail the WACK. (And we could not detect the problem before because it passed skip-dumpbin-checks)

``` D:\installed\x64-uwp\include\asio/detail/impl/win_iocp_io_context.ipp(535): error C2039: 'VerSetConditionMask': is not a member of '`global namespace'' D:\installed\x64-uwp\include\asio/detail/impl/win_iocp_io_context.ipp(535): error C3861: 'VerSetConditionMask': identifier not found D:\installed\x64-uwp\include\asio/detail/impl/win_iocp_io_context.ipp(538): error C2039: 'VerifyVersionInfo': is not a member of '`global namespace'' D:\installed\x64-uwp\include\asio/detail/impl/win_iocp_io_context.ipp(538): error C3861: 'VerifyVersionInfo': identifier not found ```

Neumann-A · 2023-02-18T08:01:57Z

[vcpkg-gfortran] Also not supported on UWP.

Be aware that we had the discussion somewhere already.

BillyONeal · 2023-02-18T08:05:51Z

Be aware that we had the discussion somewhere already.

I don't necessarily want to relitigate something that has been litigated before but I see little reason in claiming to people that something is available only for it to blow up in their face when they try to ship. Do you have a link to the previous discussion which may have landed on mitigations?

Neumann-A · 2023-02-18T08:11:35Z

I don't necessarily want to relitigate something that has been litigated before but I see little reason in claiming to people that something is available only for it to blow up in their face when they try to ship. Do you have a link to the previous discussion which may have landed on mitigations?

#19413 (review)

seems like the result was that uwp is already broken but it was never marked as broken.

BillyONeal · 2023-02-18T08:12:59Z

seems like the result was that uwp is already broken but it was never marked as broken.

Yeah there I said

Given that UWP is already broken for gfortran et al. here, don't worry about UWP interaction in whatever the solution is.

so it seems like this is just documenting that it's broken rather than actually breaking anything.

Neumann-A · 2023-02-18T08:14:35Z

so it seems like this is just documenting that it's broken rather than actually breaking anything.

That is because the lapack dependency on uwp is fulfilled via clapack.

dg0yt · 2023-02-18T08:01:15Z

ports/blend2d/usage_static.txt

+    find_package(blend2d CONFIG REQUIRED)
+    target_link_libraries(main PRIVATE blend2d::blend2d)
+
+Also, define BL_STATIC before any blend2d includes.


Shouldn't this be burned in in some way?

Yes, this is bad. But this PR isn't making that worse.

ports/monkeys-audio/vcpkg.json

BillyONeal · 2023-02-18T08:18:10Z

[lapack-reference]:
warning: Detected outdated dynamic CRT in the following files:
D:\packages\lapack-reference_x86-windows\debug\bin\liblapack.dll:msvcrt.dll
D:\packages\lapack-reference_x86-windows\bin\liblapack.dll:msvcrt.dll
To inspect the dll files, use:
dumpbin.exe /dependents mylibfile.dll

…2-15 # Conflicts: # versions/m-/monkeys-audio.json

autoantwort · 2023-02-20T13:47:50Z

Hm I don't understand why it is necessary to bump the port version of every boost port.

BillyONeal · 2023-02-21T09:25:34Z

Hm I don't understand why it is necessary to bump the port version of every boost port.

#29540 and #29481 touch boost-build that the entire Boost word depends on, but forgot to rerun generate-ports.ps1. Really, only those ports which transitively depend on boost-random should need to be affected here.

Actions can no longer approve itself.

…2-15 # Conflicts: # ports/openimageio/portfile.cmake # ports/vtk/pegtl.patch # versions/m-/monkeys-audio.json # versions/o-/openimageio.json # versions/v-/vtk.json

BillyONeal · 2023-02-21T18:44:15Z

All VTK changes removed due to 8c0fe4a landing.

…2-15

BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Feb 15, 2023

github-actions bot previously approved these changes Feb 15, 2023

View reviewed changes

LilyWangLL assigned jimwang118 Feb 15, 2023

BillyONeal dismissed github-actions[bot]’s stale review via 3ddb698 February 16, 2023 20:40

BillyONeal force-pushed the tool-release-2023-02-15 branch 2 times, most recently from 3ddb698 to eb5a8e4 Compare February 16, 2023 20:40

Update vcpkg-tool to 2023-02-16.

c3c71c3

BillyONeal force-pushed the tool-release-2023-02-15 branch from eb5a8e4 to c3c71c3 Compare February 16, 2023 20:41

github-actions bot previously approved these changes Feb 16, 2023

View reviewed changes

BillyONeal changed the title ~~Update vcpkg-tool to 2023-02-15.~~ Update vcpkg-tool to 2023-02-16. Feb 16, 2023

walbourn mentioned this pull request Feb 17, 2023

[community triplet] adds triplets for building for the Xbox platform #29210

Merged

[vcpkg-gfortran] Use VCPKG_POLICY_ALLOW_OBSOLETE_MSVCRT rather than V…

be95ce7

…CPKG_POLICY_SKIP_DUMPBIN_CHECKS now that checking for msvc no longer requires dumpbin.

BillyONeal added 9 commits February 17, 2023 20:05

[blend2d] Fix usage post-build check failure and add quotes.

ca1cb8a

[clipper2,jxrlib] Fix usage install.

88775f5

[qt5-x11extras] Disable on all Windows.

9cd2087

This never worked on Windows but was guarded before by failed dependencies on arm.

[boost] Add "supports": "!uwp" to boost-random, and rerun generate-po…

99c4b28

…rts.ps1. microsoft#29540 and microsoft#29481 forgot to rerun generate-ports.ps1. Note that the default port-version was bumped because most everything depends on boost-build that change touched.

[monkeys-audio] Use /Z7 and no /Gm to avoid spurious compiler crashes.

64bd5da

[openmesh] Fix usage install on case-sensitive file systems.

71df8be

[functions-framework-cpp] Mark unsupported on uwp.

45223ae

[openimageio] Cherry-pick arm64-windows fixes.

4fa6f5c

[vtk] Ensure vtk uses pegtl-2, as declared in its dependencies list, …

6b9ac36

…rather than pegtl, if that port happened to get installed first.

BillyONeal dismissed github-actions[bot]’s stale review via 04e8c53 February 18, 2023 07:37

dg0yt reviewed Feb 18, 2023

View reviewed changes

[lapack-reference] Uses msvcrt.

e1d748c

Merge remote-tracking branch 'origin/master' into tool-release-2023-0…

4afabf9

…2-15 # Conflicts: # versions/m-/monkeys-audio.json

dg0yt mentioned this pull request Feb 18, 2023

[vtk] Fix proj, trim feature dependencies #29703

Merged

7 tasks

autoantwort mentioned this pull request Feb 20, 2023

[vcpkg upgrade] Could not find rawparse in gstreamer. #29750

Closed

Try to kick the GitHub Actions bot.

e60a35d

Merge remote-tracking branch 'origin/master' into tool-release-2023-0…

dbfc09d

…2-15 # Conflicts: # ports/openimageio/portfile.cmake # ports/vtk/pegtl.patch # versions/m-/monkeys-audio.json # versions/o-/openimageio.json # versions/v-/vtk.json

BillyONeal added 2 commits February 23, 2023 12:05

Merge remote-tracking branch 'origin/master' into tool-release-2023-0…

1eb36a6

…2-15

[monkeys-audio] Merge.

a7a6d5e

ras0219-msft approved these changes Feb 23, 2023

View reviewed changes

vicroms approved these changes Feb 23, 2023

View reviewed changes

BillyONeal merged commit 9484a57 into microsoft:master Feb 24, 2023

BillyONeal deleted the tool-release-2023-02-15 branch February 24, 2023 19:58

BillyONeal mentioned this pull request Feb 24, 2023

Don't let unsupported ports pull in dependencies microsoft/vcpkg-tool#846

Closed

FabienPean mentioned this pull request Feb 28, 2023

[arpack-ng] Workaround "outdated dynamic CRT" #29935

Merged

7 tasks

walbourn mentioned this pull request Mar 22, 2023

error: Unrecognized identifer name xbox. Add to override list in triplet file. #30122

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update vcpkg-tool to 2023-02-16. #29664

Update vcpkg-tool to 2023-02-16. #29664

BillyONeal commented Feb 15, 2023 •

edited

Loading

autoantwort commented Feb 15, 2023

dg0yt commented Feb 17, 2023

walbourn commented Feb 17, 2023

BillyONeal commented Feb 18, 2023

BillyONeal commented Feb 18, 2023

BillyONeal commented Feb 18, 2023

BillyONeal commented Feb 18, 2023

Neumann-A commented Feb 18, 2023

BillyONeal commented Feb 18, 2023

Neumann-A commented Feb 18, 2023

BillyONeal commented Feb 18, 2023

Neumann-A commented Feb 18, 2023

dg0yt Feb 18, 2023

BillyONeal Feb 18, 2023

BillyONeal commented Feb 18, 2023

autoantwort commented Feb 20, 2023

BillyONeal commented Feb 21, 2023

BillyONeal commented Feb 21, 2023

Update vcpkg-tool to 2023-02-16. #29664

Update vcpkg-tool to 2023-02-16. #29664

Conversation

BillyONeal commented Feb 15, 2023 • edited Loading

autoantwort commented Feb 15, 2023

dg0yt commented Feb 17, 2023

walbourn commented Feb 17, 2023

BillyONeal commented Feb 18, 2023

BillyONeal commented Feb 18, 2023

BillyONeal commented Feb 18, 2023

BillyONeal commented Feb 18, 2023

Neumann-A commented Feb 18, 2023

BillyONeal commented Feb 18, 2023

Neumann-A commented Feb 18, 2023

BillyONeal commented Feb 18, 2023

Neumann-A commented Feb 18, 2023

dg0yt Feb 18, 2023

Choose a reason for hiding this comment

BillyONeal Feb 18, 2023

Choose a reason for hiding this comment

BillyONeal commented Feb 18, 2023

autoantwort commented Feb 20, 2023

BillyONeal commented Feb 21, 2023

BillyONeal commented Feb 21, 2023

BillyONeal commented Feb 15, 2023 •

edited

Loading