Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python3] adjust sysconfig include dir to match vcpkg layout #34888

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

Neumann-A
Copy link
Contributor

Fixes #34876

@Cheney-W Cheney-W self-assigned this Nov 3, 2023
@Cheney-W Cheney-W added the category:port-bug The issue is with a library, which is something the port should already support label Nov 3, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Nov 6, 2023
@JavierMatosD JavierMatosD merged commit 1802d39 into microsoft:master Nov 6, 2023
15 checks passed
@Neumann-A Neumann-A deleted the fix-python-sysconfig branch November 6, 2023 20:10
@m-kuhn
Copy link
Contributor

m-kuhn commented Feb 10, 2024

@Neumann-A

This looks unexpected to me (and breaks my attempts to build PyQt6 where Python.h is not found due to a wrong include path):

./tools/python3/python3.11 -c "import pprint;import sysconfig; pprint.pprint(sysconfig.get_paths())"                                                                     
{'data': '/home/mkuhn/dev/vcpkg/installed/x64-linux',
 'include': '/home/mkuhn/dev/vcpkg/include/python3.11',
 'platinclude': '/home/mkuhn/dev/vcpkg/include/python3.11',
 'platlib': '/home/mkuhn/dev/vcpkg/installed/x64-linux/lib/python3.11/site-packages',
 'platstdlib': '/home/mkuhn/dev/vcpkg/installed/x64-linux/lib/python3.11',
 'purelib': '/home/mkuhn/dev/vcpkg/installed/x64-linux/lib/python3.11/site-packages',
 'scripts': '/home/mkuhn/dev/vcpkg/installed/x64-linux/bin',
 'stdlib': '/home/mkuhn/dev/vcpkg/installed/x64-linux/lib/python3.11'}

m-kuhn referenced this pull request in open-vcpkg/python-registry Feb 10, 2024
@m-kuhn
Copy link
Contributor

m-kuhn commented Feb 10, 2024

Looks fine on windows:

import pprint;import sysconfig; pprint.pprint(sysconfig.get_paths())
{'data': 'C:\\Users\\Public\\dev\\vcpkg\\installed\\x64-windows\\tools\\python3',
 'include': 'C:\\Users\\Public\\dev\\vcpkg\\installed\\x64-windows\\include\\python3.11',
 'platinclude': 'C:\\Users\\Public\\dev\\vcpkg\\installed\\x64-windows\\include\\python3.11',
 'platlib': 'C:\\Users\\Public\\dev\\vcpkg\\installed\\x64-windows\\tools\\python3\\Lib\\site-packages',
 'platstdlib': 'C:\\Users\\Public\\dev\\vcpkg\\installed\\x64-windows\\tools\\python3\\Lib',
 'purelib': 'C:\\Users\\Public\\dev\\vcpkg\\installed\\x64-windows\\tools\\python3\\Lib\\site-packages',
 'scripts': 'C:\\Users\\Public\\dev\\vcpkg\\installed\\x64-windows\\tools\\python3\\Scripts',
 'stdlib': 'C:\\Users\\Public\\dev\\vcpkg\\installed\\x64-windows\\tools\\python3\\Lib'}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[python] Fix include paths
5 participants