Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scripts/posh-vcpkg] Update to 0.0.2 #38317

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[scripts/posh-vcpkg] Update to 0.0.2 #38317

wants to merge 3 commits into from
+32 −36

Conversation

WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Apr 22, 2024 •
edited
Loading

@WangWeiLin-MV WangWeiLin-MV added info:internal This PR or Issue was filed by the vcpkg team. category:port-bug The issue is with a library, which is something the port should already support labels Apr 22, 2024
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review April 22, 2024 10:14
@WangWeiLin-MV WangWeiLin-MV added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly and removed category:port-bug The issue is with a library, which is something the port should already support labels Apr 22, 2024
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Apr 24, 2024
@JavierMatosD JavierMatosD added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Apr 24, 2024
@BillyONeal
Copy link
Member

  1. Since you lifted the lid on this, can tests be added?
  2. Should the version number on the module change?

@WangWeiLin-MV WangWeiLin-MV removed the info:reviewed Pull Request changes follow basic guidelines label Apr 25, 2024
@WangWeiLin-MV WangWeiLin-MV marked this pull request as draft April 25, 2024 05:01
@WangWeiLin-MV WangWeiLin-MV force-pushed the scripts/posh-vcpkg/change-tab-expansion-to-argument-completion branch 7 times, most recently from 0af9d50 to e7f11b9 Compare April 30, 2024 04:11
@WangWeiLin-MV WangWeiLin-MV changed the title [vcpkg/scripts] Change TabExpansion to Register-ArgumentCompleter of posh-vcpkg [scripts/posh-vcpkg] Change TabExpansion to Register-ArgumentCompleter Apr 30, 2024
@WangWeiLin-MV
Copy link
Contributor Author

WangWeiLin-MV commented Apr 30, 2024 •
edited
Loading

The scripts/posh-vcpkg tests pass with the following test cases:

  • Context Complete command name tests
  • Context Complete command spaces tests
  • Context Complete command intermediate tests
  • Context Complete subcommand tests
  • Context Complete complex tests

@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review April 30, 2024 04:52
@WangWeiLin-MV
Copy link
Contributor Author

WangWeiLin-MV commented Jun 14, 2024 •
edited
Loading

Circular dependency: vcpkg-tool release tests depend on vcpkg-registry (current repository), and posh-vcpkg depends on vcpkg-tool behavior.

The test cases should be moved to vcpkg-tool repository.

Changes were moved to vcpkg-tool repository microsoft/vcpkg-tool#1512

@WangWeiLin-MV WangWeiLin-MV marked this pull request as draft June 14, 2024 08:46
@WangWeiLin-MV WangWeiLin-MV force-pushed the scripts/posh-vcpkg/change-tab-expansion-to-argument-completion branch from bfb1026 to 8f6a8e9 Compare June 14, 2024 10:05
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review June 17, 2024 05:48
@F-park F-park mentioned this pull request Jul 19, 2024
Open
@WangWeiLin-MV WangWeiLin-MV marked this pull request as draft August 23, 2024 08:54
@WangWeiLin-MV WangWeiLin-MV force-pushed the scripts/posh-vcpkg/change-tab-expansion-to-argument-completion branch from 8f6a8e9 to 4c18ebf Compare October 16, 2024 10:53
@WangWeiLin-MV WangWeiLin-MV force-pushed the scripts/posh-vcpkg/change-tab-expansion-to-argument-completion branch from 4c18ebf to 97d4dc8 Compare October 16, 2024 10:58
@WangWeiLin-MV WangWeiLin-MV changed the title [scripts/posh-vcpkg] Change TabExpansion to Register-ArgumentCompleter [scripts/posh-vcpkg] Update to 0.0.2 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JonLiu1993 JonLiu1993

@jimwang118 jimwang118

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:internal This PR or Issue was filed by the vcpkg team. requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression pwsh tab completion doesn't work
5 participants
@WangWeiLin-MV @BillyONeal @JavierMatosD @JonLiu1993 @jimwang118