-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg_from_github] Allow targeting Github Enterprise instances #5719
Conversation
Allow setting of a URL so vcpkg can download repositories hosted on GitHub Enterprise instances. Additionally provides a way to set the authorization token when downloading private repositories.
I haven't written the documentation for the new values yet. I wanted to know if there was any preference to the variable names. Currently its |
@vicroms not sure what the best naming of things are. My only concern with With |
@Rastaban @ras0219-msft any feedback on this? |
@vicroms @Rastaban @ras0219-msft is this something that you all don't want to support? The PR has been open for almost 2 months now and I'm not sure what is going on. |
Hey @vicroms @Rastaban @ras0219-msft this PR has been open for over 5 months any feedback? |
Rename TOKEN -> AUTHORIZATION_TOKEN
Thank you for your patience and thank you for the PR! The design LGTM; I renamed the two parameters to Assuming no CI issues, this is ready to merge. |
Allow setting of a URL so vcpkg can download repositories hosted on GitHub Enterprise
instances. Additionally provides a way to set the authorization token when downloading
private repositories.