Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libmagic] Add new port #8650

Merged

Conversation

NancyLi1013
Copy link
Contributor

@NancyLi1013 NancyLi1013 commented Oct 18, 2019

This library can be used to classify files according to magic number tests.
libmagic currently doesn't support Windows platform.

Related issue #7895
The latest version 5.37 in ftp://ftp.astron.com/pub/file/ cannot be reached, so I get the source from here https://github.com/threatstack/libmagic.

No feature need to test.

@NancyLi1013 NancyLi1013 added the info:internal This PR or Issue was filed by the vcpkg team. label Oct 18, 2019
ports/libmagic/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 marked this pull request as ready for review October 18, 2019 06:19
@zrax
Copy link
Contributor

zrax commented Oct 22, 2019

The threatstack mirror is very old (5 years or so)... If FTP can't be used, there is a much more up-to-date official mirror on github at https://github.com/file/file

@NancyLi1013
Copy link
Contributor Author

@zrax thanks for your info. I have updated.

@ras0219-msft ras0219-msft self-assigned this Oct 29, 2019
@JackBoosY
Copy link
Contributor

/azp run

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Dec 10, 2019
@dan-shaw
Copy link
Contributor

LGTM

@JackBoosY
Copy link
Contributor

/azp run

@dan-shaw dan-shaw assigned dan-shaw and unassigned ras0219-msft Dec 11, 2019
@ras0219-msft
Copy link
Contributor

Please modify ci.baseline.txt to account for the windows failures

@NancyLi1013
Copy link
Contributor Author

/azp run

@dan-shaw dan-shaw merged commit e13ed95 into microsoft:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants