-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libmagic] Add new port #8650
Merged
dan-shaw
merged 8 commits into
microsoft:master
from
NancyLi1013:dev/NancyLi/7895/add-libmagic
Jan 6, 2020
Merged
[libmagic] Add new port #8650
dan-shaw
merged 8 commits into
microsoft:master
from
NancyLi1013:dev/NancyLi/7895/add-libmagic
Jan 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
the
info:internal
This PR or Issue was filed by the vcpkg team.
label
Oct 18, 2019
JackBoosY
suggested changes
Oct 18, 2019
JackBoosY
approved these changes
Oct 18, 2019
…NancyLi/7895/add-libmagic
The threatstack mirror is very old (5 years or so)... If FTP can't be used, there is a much more up-to-date official mirror on github at https://github.com/file/file |
@zrax thanks for your info. I have updated. |
/azp run |
dan-shaw
approved these changes
Dec 10, 2019
LGTM |
/azp run |
Please modify ci.baseline.txt to account for the windows failures |
…NancyLi/7895/add-libmagic
/azp run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
info:internal
This PR or Issue was filed by the vcpkg team.
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library can be used to classify files according to magic number tests.
libmagic
currently doesn't support Windows platform.Related issue #7895
The latest version 5.37 in ftp://ftp.astron.com/pub/file/ cannot be reached, so I get the source from here https://github.com/threatstack/libmagic.
No feature need to test.