Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols list: give declarations a different icon than definitions #3117

Open
JeFrRe opened this issue Jan 30, 2019 · 7 comments
Open

Symbols list: give declarations a different icon than definitions #3117

JeFrRe opened this issue Jan 30, 2019 · 7 comments

Comments

@JeFrRe
Copy link

JeFrRe commented Jan 30, 2019

In the symbols list, is it possible to give the declarations a different icon than the one for the definitions?

Or put the declaration marker (declaration) at the start of the line? Like it is done in the navigation list. (which would also be more consistent I think)

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Jan 31, 2019

The fix for adding a declaration icon is being tracked by VS Code itself at microsoft/vscode#23927 .

However, I believe we can move the (declaration) to the front.

UPDATE: The fix was made, but the check in has been delayed till after the March release ships.

@JeFrRe
Copy link
Author

JeFrRe commented Jan 31, 2019 via email

@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Feb 6, 2019
@sean-mcmanus sean-mcmanus removed their assignment Feb 6, 2019
@sean-mcmanus sean-mcmanus modified the milestones: March 2019, April 2019 Mar 12, 2019
@sean-mcmanus sean-mcmanus removed the fixed Check the Milestone for the release in which the fix is or will be available. label Mar 27, 2019
@sean-mcmanus sean-mcmanus modified the milestones: April 2019, Backlog Mar 27, 2019
@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Mar 27, 2019

We decided not to fix this, because:

  1. It causes the declaration and definition to not be sorted next to each other.
  2. We're concerned that non-English speakers might be confused by what "(declaration)" is if it's more visible on the left side.
  3. We were concerned that "(declaration) " was too long to be on the left and shorter things like "(decl)" or some symbol might not be understandable.
  4. You can hover over the symbol to see (declaration)-ness on the right side.

If more people complain about this then we could reconsiders.

Or VS Code could fix microsoft/vscode#23927 .

@bobbrow bobbrow changed the title Symbols list - Declarations Symbols list: give declarations a different icon than definitions Mar 18, 2020
@bobbrow
Copy link
Member

bobbrow commented Mar 18, 2020

It looks like the linked VS Code issue has been completed.

@bobbrow bobbrow modified the milestones: Backlog, On Deck Mar 18, 2020
@bobbrow bobbrow modified the milestones: On Deck, 1.1.0 Aug 28, 2020
@bobbrow bobbrow modified the milestones: 1.1.0, 1.2.0 Oct 20, 2020
@elahehrashedi elahehrashedi self-assigned this Nov 30, 2020
@sean-mcmanus
Copy link
Collaborator

@bobbrow VS Code didn't add a declaration enum/tag/icon (just "deprecated"). Should we file a new issue with VS Code or what?

@elahehrashedi
Copy link
Contributor

follow from here: microsoft/vscode#113845

@mrx23dot
Copy link

It's so annoying to see duplicates in C files

image

If implementation is in the file there is no point showing its prototype,
but in header it's useful to show the prototype if no implementation.

tl;dr only show one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants