Remove some redundant code related to revealIfOpen setting
#13922
+1
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colengms
changed the title
revealIfOpen settingrevealIfOpen setting
sean-mcmanus
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the code involved was attempting to reveal the document if already open in another tab group (which is not the default behavior of VS Code), as that seemed more correct. A user then contributed a change to cause it to properly adhere to the
revealIfOpensetting: https://github.com/microsoft/vscode-cpptools/pull/8857/filesHowever,
showTextDocumentwill honor therevealIfOpensetting by default, making a lot of that code unnecessary. This change removes unnecessary code and does not change the current behavior.Related:
#13867
microsoft/vscode#263012