Add a setting to manage inactive region colorization #1604
Conversation
| @@ -139,6 +139,12 @@ | |||
| "description": "Controls whether suspected compile errors detected by the IntelliSense engine will be reported back to the editor. Warnings about #includes that could not be located will always be reported to the editor. This setting is ignored by the Tag Parser engine.", | |||
| "scope": "resource" | |||
| }, | |||
| "C_Cpp.dimInactiveRegions": { | |||
| "type": "boolean", | |||
There was a problem hiding this comment.
Should we be forward looking and change this to an opacity setting, e.g. 100 would be equal to false? Then when VS Code enables real opacity this setting could be used to change the amount of opacity.
There was a problem hiding this comment.
I'm open to that, but has VSCode committed to giving us an opacity setting?
There was a problem hiding this comment.
We have opacity, we just don't have access to the opacity AND current color, OR just the opacity w/o color. They have not responded to my GitHub issue, but I could bump the issue until they bother to respond to me.
There was a problem hiding this comment.
I assume they would "eventually" implement text opacity to match VS 2017, it seems like adding an opacity setting now would confuse users since it wouldn't work (unless we make it affect the gray color).
There was a problem hiding this comment.
@bobbrow @sean-mcmanus Just bumping this while looking through this PR to learn how to do my own setting. As of 3 days ago an opacity property was exposed. microsoft/vscode#43004
It was merged into master, though I'm not sure when it will ship. As soon as it is, however, we can expose our own opacity setting as a 0-100 or similar as Sean suggested.
It still needs a corresponding change from the language server process so that the lightbulb and toggle commands work, but this handles the TypeScript part.