Fix Fish shell installation

[andreiborisov]

Fixes #1501

[eitsupi]

Does this change fix #1501?
The log show that the fish installation was not successful?

[eitsupi]

I think the fish installation was successful because I see Installing Fisher... in the log.
What is failing is the installation of Fisher.

vscode-dev-containers/script-library/fish-debian.sh

Lines 85 to 88 in 172a918

	echo "Installing Fisher..."
	fish -c 'curl -sL https://raw.githubusercontent.com/jorgebucaran/fisher/main/functions/fisher.fish | source && fisher install jorgebucaran/fisher'
	if [ "${USERNAME}" != "root" ]; then
	sudo -u $USERNAME fish -c 'curl -sL https://raw.githubusercontent.com/jorgebucaran/fisher/main/functions/fisher.fish | source && fisher install jorgebucaran/fisher'

The error came from this line.
https://github.com/jorgebucaran/fisher/blob/cf4c6cc561b6b495fc8ac0c3b31482f89dd08d49/functions/fisher.fish#L197

[andreiborisov]

@eitsupi the issues was check_packages fish not working properly by failing to run apt-get update and as a result the script installing ancient fish version from the system package list. It has a slightly different syntax, hence fisher fails to work properly since it only supports fish v3 syntax and greater.

tldr: it should fix it.

[eitsupi]

That makes sense. Thank you for working on it!

This change should be revert in this PR, I think.
https://github.com/microsoft/vscode-dev-containers/pull/1500/files#diff-b4fcdb4d2b5b4dd46c896cb5bfa0a42e633340c263aa0238d71dce261bbd5c36R112

And version check e.x. fish -v in this script maybe useful for debug?

[andreiborisov]

@eitsupi good suggestion! Added version check🙌

[eitsupi]

@andreiborisov Thanks!
I don't think the test is currently running, could you uncomment the following and re-enable the test?
https://github.com/microsoft/vscode-dev-containers/pull/1500/files#diff-b4fcdb4d2b5b4dd46c896cb5bfa0a42e633340c263aa0238d71dce261bbd5c36R112

[andreiborisov]

@joshspicer seem to be good for the merge🙌🏻

[joshspicer]

Thank you guys for your continued support! 🚀