-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go to Definition goes to decompiled code from assembly instead of the actual code #40
Comments
Same here - #41 |
@timheuer This issue is also being discussed in the Roslyn repo: dotnet/roslyn#68472 |
Just to follow up on this -- we think we have the problem root-caused and a fix written up, so thank you all for the reports! |
Does this also affect generated source files i.e. *.g.cs or am I experiencing a different issue? |
It would be my guess:
|
@BinToss I'd say assume that's a separate issue until we've proven otherwise. Do file another issue if you haven't already! |
It seems correct I just disabled the "C# devkit" now "goto definition is working for me" |
We shipped version 2.0.212 of the C# extension earlier today which contains a fix for this issue. Thank you all for the reports and sorry for the trouble on this one! |
When we were looking to see if Dev Kit was installed to know whether we should trigger our own project system, we checked _wasActivatedWithCSharpDevkit; but that wasn't set since we don't await the server launch a few lines before. The field would be unset and as a result we'd run both. Fixes microsoft/vscode-dotnettools#40 Fixes dotnet/roslyn#68472 Fixes #5711
Type: Bug
Steps to reproduce
Press F12 (Go to definition) on code defined in another project within the same solution.
Expected behavior
Go to the code in the solution.
Actual behavior
Pressing F12 will go to decompiled code from the assembly in the obj directory. Go to definition within the same project works as it should.
Extension version: 0.1.83
VS Code version: Code 1.78.2 (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T15:00:40.428Z)
OS version: Darwin arm64 22.5.0
Modes:
Sandboxed: Yes
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
A/B Experiments
The text was updated successfully, but these errors were encountered: