Skip to content

fix issue: java11 template cannot be found. #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2018
Merged

fix issue: java11 template cannot be found. #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
480596f
fix issue: java11 template cannot be found.
andxu Oct 30, 2018
228c516
1. use jdkSpecificTemplateRoot to reduce join two times.
andxu Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/controllers/projectController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,15 @@ export class ProjectController {
const templateRoot: string = path.join(this.context.extensionPath, "templates");
const projectFile: string = path.join(projectRoot, ".project");
try {
let jdkSpecificTemplateRoot: string = path.join(templateRoot, `Java${javaVersion}`);
if (!await fse.pathExists(jdkSpecificTemplateRoot)) {
// fall back to 8
jdkSpecificTemplateRoot = path.join(templateRoot, `Java8`);
}
await fse.ensureDir(projectRoot);

await Promise.all([
fse.copy(path.join(templateRoot, "App.java.sample"), path.join(projectRoot, "src", "app", "App.java")),
fse.copy(path.join(templateRoot, `Java${javaVersion}`), projectRoot),
fse.copy(jdkSpecificTemplateRoot, projectRoot),
fse.copy(path.join(templateRoot, ".project"), path.join(projectRoot, ".project")),
fse.ensureDir(path.join(projectRoot, "bin")),
]);
Expand Down
6 changes: 6 additions & 0 deletions templates/Java11/.classpath
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the JDK 9/10 support

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JUST to keep 9/10 since there is no reason why we forbid the obsoleted the version strictly

<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-10"/>
<classpathentry kind="src" path="src"/>
<classpathentry kind="output" path="bin"/>
</classpath>
11 changes: 11 additions & 0 deletions templates/Java11/.settings/org.eclipse.jdt.core.prefs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
eclipse.preferences.version=1
org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
org.eclipse.jdt.core.compiler.codegen.targetPlatform=10
org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
org.eclipse.jdt.core.compiler.compliance=10
org.eclipse.jdt.core.compiler.debug.lineNumber=generate
org.eclipse.jdt.core.compiler.debug.localVariable=generate
org.eclipse.jdt.core.compiler.debug.sourceFile=generate
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
org.eclipse.jdt.core.compiler.source=10