This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
allow es imports, update ts and use their helper methods #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to pipe in my TS directly since I only use the incremental TS compiler in js-debug which didn't seem to place nice with this package.
I noticed I wasn't getting any results since vscode-nls didn't understand ES6 imports. There actually was a function
isImportNode
, but that was not used anywhere. I made that detectimport * as nls
andimport nls = require(...)
expressions.While I was there I bumped TS to the latest version which includes predicate methods so, we no longer need all our own
is*
functions.