fix conda env refresh not waiting for promises #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was causing the refresh function to return with empty or missing environments before waiting for all async calls that update the env collection
almarouk
force-pushed
the
fixCondaEnvResfresh
branch
from
10c5b35 to
83de4ed
Compare
eleanorjboyd
approved these changes
Sep 8, 2025
|
great catch! Thank you for adding this and sorry for the delay |
karthiknadig
approved these changes
Sep 8, 2025
eleanorjboyd
added a commit
to eleanorjboyd/vscode-python-environments
that referenced
this pull request
Sep 10, 2025
This was causing the refresh function to return with empty or missing environments before waiting for all async calls that update the env collection. This bug was somehow causing duplicate environments to appear in the list of environments. Co-authored-by: Eleanor Boyd <26030610+eleanorjboyd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing the refresh function to return with empty or missing environments before waiting for all async calls that update the env collection.
This bug was somehow causing duplicate environments to appear in the list of environments.