Skip to content

switch to using inspect for setting to check for user explicit value #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

switch to using inspect for setting to check for user explicit value #803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,15 +596,9 @@ export async function disposeAll(disposables: IDisposable[]): Promise<void> {
}

/**
* Resolves and sets the default Python interpreter for the workspace based on the
* 'python.defaultInterpreterPath' setting and the selected environment manager.
* If the setting is present and no default environment manager is set (or is venv),
* attempts to resolve the interpreter path using the native finder. If the resolved
* path differs from the configured path, then creates and sets a PythonEnvironment
* object for the workspace.
*
* @param nativeFinder - The NativePythonFinder instance used to resolve interpreter paths.
* @param envManagers - The EnvironmentManagers instance containing all registered managers.
* Sets the default Python interpreter for the workspace if the user has not explicitly set 'defaultEnvManager' or it is set to venv.
* @param nativeFinder - used to resolve interpreter paths.
* @param envManagers - contains all registered managers.
* @param api - The PythonEnvironmentApi for environment resolution and setting.
*/
async function resolveDefaultInterpreter(
Expand All @@ -615,9 +609,13 @@ async function resolveDefaultInterpreter(
const defaultInterpreterPath = getConfiguration('python').get<string>('defaultInterpreterPath');

if (defaultInterpreterPath) {
const defaultManager = getConfiguration('python-envs').get<string>('defaultEnvManager', 'undefined');
traceInfo(`resolveDefaultInterpreter setting exists; found defaultEnvManager: ${defaultManager}. `);
if (!defaultManager || defaultManager === 'ms-python.python:venv') {
const config = getConfiguration('python-envs');
const inspect = config.inspect<string>('defaultEnvManager');
const userDefinedDefaultManager =
inspect?.workspaceFolderValue !== undefined ||
inspect?.workspaceValue !== undefined ||
inspect?.globalValue !== undefined;
if (!userDefinedDefaultManager) {
try {
const resolved: NativeEnvInfo = await nativeFinder.resolve(defaultInterpreterPath);
if (resolved && resolved.executable) {
Expand Down
Loading