'Go to reference' does not traverse through relative imports

[idchlife]

Environment data

• VS Code version: 1.21.p
• Extension version (available under the Extensions sidebar): 2018.2.1
• OS and version: macOS 10.13.3
• Python version (& distribution if applicable, e.g. Anaconda): 3.6.4
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): pipenv with proper python path in vscode
• Relevant/affected Python packages and their versions: flask_restplus

Actual behavior

Going to definition for Namespace from flask_restplus goes to __init__.py instead of file namespace.py.
Also vscode shows error "instance of Namespace has no member ..." etc, since vscode-python cannot learn that

from .namespace import ...

is

from namespace import ...

Expected behavior

No errors, going to definition is fine

Steps to reproduce:

1. Install pipenv, config vscode to work with python version
2. Install flask_restplus, import Namespace from library, try to go inside and go to definition of Namespace in init.py file
3. See vscode-python does not recognize "from .namespace import" and does not lead anywhere
4. Remove dot and repeat
5. See everything is working fine now, but source has been modified, so it's not a solution

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

XXX

[MikhailArkhipov]

Probably Jedi issue. We need to check if new engine handles this correctly.

[MikhailArkhipov]

VS engine: microsoft/PTVS#949

[MikhailArkhipov]

Jedi claims it supports relatives. davidhalter/jedi#973, davidhalter/jedi#959

[brettcannon]

So Jedi does understand relative imports. This is actually an issue of Jedi not traversing through direct object importation. For instance, if you have:

# pkg/__init__.py
from . import b

# pkg/B.py
b = None

# pkg/A.py
from . import B
print(B.b)

from .B import b
print(b)

from . import b as alt_b
print(alt_b)

The first example works fine. The second and third examples, though, go to the import statements (which you can do Go to Definition on and it will get you to the code).

Now the question is whether this is actually wrong behaviour. From Jedi's perspective, when you directly import an object it's definition is the import since that's how you got the object and so that's the definition. IOW it's putting that import on the same level as if you did b = None directly in your code. For modules you imported, though, it realizes you didn't directly pull that object in, and so it navigates the namespace to the object.

For me I can see both how Jedi does it and what the OP is asking for as legitimate. The former tells you how the name ended up in your namespace while the latter shows you the code. Both are useful for different reasons, although if we take the OP's requested approach we lose the latter while the former simply requires more commands to reach the same result.