jediEnabled = false isn't automatically migrated to languageServer = Microsoft

[fireattack]

Environment data

Version: 1.46.0-insider
Commit: b1ef2bf
Date: 2020-06-05T12:30:13.870Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 6.1.7601

Expected behaviour

jediEnabled = false should be migrated to languageServer = Microsoft

Actual behaviour

It doesn't. After updating, languageServer became Jedi.

Steps to reproduce:

1. Disable extension auto update ("extensions.autoUpdate": false).
2. Manually install an older version of Python. I use 2020.5.80290.
3. Set jediEnabled to false. languageServer setting doesn't seem to matter, I tried to leave it as Jedi or Microsoft, no difference.
4. Manually update Python extension to newest (2020.6.88468), and reload.

[MikhailArkhipov]

I'll take it.

[WhistleWhileYouWork]

Version: 1.46.1 (user setup)
Commit: cd9ea6488829f560dc949a8b2fb789f3cdc05f5d
Date: 2020-06-17T21:13:20.174Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

I am using Visual Studio Intellicode 1.2.8 and this extension version 2020.6.89148 (which claims to fix this issue and references it in the Changelog). However, after removing python.jediEnabled: false, the extension wants to update the python.languageServer to Jedi and reload the window. Upon reloading the window, the Intellicode extension wants to update the setting to Microsoft and again reload (IntelliCode Python support requires you to use the Microsoft Python Language Server (preview)). Is the changelog incorrect? The update is dated June 17, this issue seems to have been fixed on the 18th.

If I create and set python.jediEnabled: false, the extension does not try to change python.languageServer to Jedi and will leave it as Microsoft.

[jakebailey]

Who is removing jediEnabled? You, or the extension? The latest release does not change jediEnabled.

If jediEnabled is false, then that imples the language server should be used, so the setting is moved. If it's unset, then that means Jedi, though as the default it should not be set at all. IntelliCode is a plugin for the language server, so asks the setting to be changed from Jedi (since it doesn't work with that setup).

If python.languageServer is set at all, it won't be touched, and nothing will change.

[AmericanY]

@jakebailey

"python.jediEnabled": false

is now considered as unknown configuration setting after the latest update of the ext.

By the way, if you set python.languageServer to the default from the GNU settings page. so python.languageServer will be removed from the JSON settings.

Now, my settings as

    "python.jediEnabled": false,
    "python.languageServer": "Microsoft"

and it's works fine

[WhistleWhileYouWork]

Who is removing jediEnabled? You, or the extension? The latest release does not change jediEnabled.

If jediEnabled is false, then that imples the language server should be used, so the setting is moved. If it's unset, then that means Jedi, though as the default it should not be set at all. IntelliCode is a plugin for the language server, so asks the setting to be changed from Jedi (since it doesn't work with that setup).

If python.languageServer is set at all, it won't be touched, and nothing will change.

It's what @AmericanY says:

'"python.jediEnabled": false' is now considered as unknown configuration setting after the latest update of the ext.

Also the Changelog for 2020.6.0 states

Removed python.jediEnabled setting in favor of python.languageServer. Instead of "python.jediEnabled": true please use "python.languageServer": "Jedi".

So it appeared 'python.jediEnabled' was no longer being used and I removed it. It is now obvious that it is being used, so the solution appears to be to just keep the setting active if we are using the Intellicode ext.