Skip to content

Add better error handling for parsing responses received from jedi #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2018
Merged

Add better error handling for parsing responses received from jedi #1868

merged 1 commit into from
Jun 5, 2018

Conversation

DonJayamanne
Copy link

Fixes #1867

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)

@DonJayamanne DonJayamanne requested a review from d3r3kk June 5, 2018 18:26
d3r3kk
d3r3kk approved these changes Jun 5, 2018
View reviewed changes
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Early out and double-check return values is great.

@DonJayamanne DonJayamanne merged commit 9075b04 into microsoft:master Jun 5, 2018
@DonJayamanne DonJayamanne deleted the issue1867JediError branch June 20, 2018 03:17
@jajcayn jajcayn mentioned this pull request Jul 10, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@d3r3kk d3r3kk d3r3kk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better exception handling when parsing responses received from Jedi
2 participants
@DonJayamanne @d3r3kk