Skip to content

Add better error handling for parsing responses received from jedi #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Add better error handling for parsing responses received from jedi #1868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/3 Code Health/1867.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add better exception handling when parsing responses received from the Jedi language service.
10 changes: 8 additions & 2 deletions src/client/providers/jediProxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,9 +391,15 @@ export class JediProxy implements Disposable {
}

responses.forEach((response) => {
if (!response) {
return;
}
const responseId = JediProxy.getProperty<number>(response, 'id');
const cmd = <IExecutionCommand<ICommandResult>>this.commands.get(responseId);
if (cmd === null) {
if (!this.commands.has(responseId)) {
return;
}
const cmd = this.commands.get(responseId);
if (!cmd) {
return;
}
this.lastCmdIdProcessed = cmd.id;
Expand Down