Skip to content

Eliminate variable value when computing data frame info #10081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Eliminate variable value when computing data frame info #10081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2 Fixes/10075.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix data viewer not opening on certain data frames.
5 changes: 3 additions & 2 deletions src/client/datascience/jupyter/jupyterVariables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,9 @@ export class JupyterVariables implements IJupyterVariables {
return defaultValue;
}

// Prep our targetVariable to send over
const variableString = JSON.stringify(targetVariable).replace(/\\n/g, '\\\\n');
// Prep our targetVariable to send over. Remove the 'value' as it's not necessary for getting df info and can have invalid data in it
const pruned = { ...targetVariable, value: '' };
const variableString = JSON.stringify(pruned);

// Setup a regex
const regexPattern =
Expand Down