Skip to content

Include interpreter name in message #10174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Include interpreter name in message #10174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/datascience/jupyter/interpreter/jupyterInterpreterSubCommandExecutionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export class JupyterInterpreterSubCommandExecutionService
}

if (productsNotInstalled.length === 1 && productsNotInstalled[0] === Product.kernelspec) {
return DataScience.jupyterKernelSpecModuleNotFound();
return DataScience.jupyterKernelSpecModuleNotFound().format(interpreter.path);
}

return getMessageForLibrariesNotInstalled(productsNotInstalled, interpreter.displayName);
Expand Down
2 changes: 1 addition & 1 deletion ...datascience/jupyter/interpreter/jupyterInterpreterSubCommandExecutionService.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ suite('Data Science - Jupyter InterpreterSubCommandExecutionService', () => {
undefined
);

assert.equal(reason, DataScience.jupyterKernelSpecModuleNotFound());
assert.equal(reason, DataScience.jupyterKernelSpecModuleNotFound().format(selectedJupyterInterpreter.path));
});
test('Can start jupyer notebook', async () => {
const output = await jupyterInterpreterExecutionService.startNotebook([], {});
Expand Down