Skip to content

Conversation

DonJayamanne
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (ds/custom_editor@93cf440). Click here to learn what that means.
The diff coverage is 68.8%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             ds/custom_editor   #10261   +/-   ##
===================================================
  Coverage                    ?   60.85%           
===================================================
  Files                       ?      570           
  Lines                       ?    30682           
  Branches                    ?     4372           
===================================================
  Hits                        ?    18673           
  Misses                      ?    11055           
  Partials                    ?      954
Impacted Files Coverage Δ
...ers/codeActionProvider/pythonCodeActionProvider.ts 100% <ø> (ø)
...datascience/jupyter/liveshare/hostJupyterServer.ts 9.9% <0%> (ø)
src/client/datascience/jupyter/jupyterServer.ts 7.52% <0%> (ø)
...lient/datascience/jupyter/jupyterSessionManager.ts 8.33% <0%> (ø)
.../datascience/interactive-common/interactiveBase.ts 5.75% <0%> (ø)
...client/datascience/jupyter/jupyterServerWrapper.ts 31.81% <100%> (ø)
src/client/providers/serviceRegistry.ts 100% <100%> (ø)
src/client/common/logger.ts 80.86% <100%> (ø)
...codeActionProvider/launchJsonCodeActionProvider.ts 100% <100%> (ø)
src/client/common/utils/localize.ts 95.07% <100%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93cf440...ccd0848. Read the comment docs.

panpan-lin and others added 10 commits February 24, 2020 09:07
* Add some output for remote situations

* Add news entry
Merely disables test for #10240
* Switch experiments settings scope to machine

* Add news item
* Added implementation

* Added tests

* Moved into providers

* Add code actions vscode mock and convert .test.ts into unit.test.ts

* Rename folders

* Dispose registered services

* News entry

* Added unit tests

* Rename core service
* Drop extra jobs from the PR-validation pipeline.

This reduces the number of build agents we are using most frequently,
without sacrificing much coverage.  Note that this relies on 2 things:

* sufficient unit test coverage
* manual "full CI" runs when there may be OS-specific concerns

With this change:

* all tests get run on 3.x on linux (including smoke)
* for 2.7 only the unit and functional tests are run (and only on linux)
* on Windows and OSX, only functional and "single workspace" tests are run

The total number of test jobs (and hence agents) drops from 13 to 8.

* Drop extra jobs from the PR-merge pipeline.

This change relies on the nightly CI run covering the full matrix.

The total number of test jobs (and hence agents) drops from 39 to 24.

* Limit # of parallel jobs in each job matrix in the PR-merge and nightly pipelines.

This reduces the max number of agents used by the PR-merge pipeline to 8
(from 24).  For the nightly pipeline it goes down from 84 to 12.  Both
will take longer to complete, but that shouldn't be a major problem.

* Add a "manual build" CI pipeline for faster turnaround.

* Do not test internal tools on lower than Python 3.7.

* Drop the temporary workaround jobs.

* (again) Do not test internal tools on lower than Python 3.7.
* Improve the perf of subsequent tests by caching interpreters

* Add back the nightly flake

* Remove coverage

* Add news entry

* Use a static map to allow promise to be cleared on new interpreters (as it was before)
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DonJayamanne DonJayamanne merged commit eea3f1c into microsoft:ds/custom_editor Feb 24, 2020
@DonJayamanne DonJayamanne deleted the mergeIntoDSCustom branch February 24, 2020 17:37
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants