Fix builtins so they don't interfere with our execution #10511
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10511 +/- ##
==========================================
- Coverage 60.86% 60.83% -0.03%
==========================================
Files 579 579
Lines 31294 31296 +2
Branches 4451 4452 +1
==========================================
- Hits 19046 19040 -6
- Misses 11285 11290 +5
- Partials 963 966 +3
Continue to review full report at Codecov.
|
| else: | ||
| del _VSCode_supportsDataExplorer | ||
| _VSCODE_evalResult = eval(_VSCODE_targetVariable["name"]) | ||
| _VSCODE_evalResult = _VSCODE_builtins.eval(_VSCODE_targetVariable["name"]) |
There was a problem hiding this comment.
We also use builtins in VariableList and VariableValue. I'd think it would be safer to do the same thing in those files as well.
There was a problem hiding this comment.
Those files aren't used anymore
There was a problem hiding this comment.
I could just delete them I guess.
There was a problem hiding this comment.
Actually they're still used to get variables in our ipython tests. But they don't need the update. They're just used to test the other two files. Maybe I should move them instead to the test directory
There was a problem hiding this comment.
That's true, I forgot they were not used anymore. Just saw them when searching for other builtins.
|
Kudos, SonarCloud Quality Gate passed!
|
* master: Fix flakey file system tests (#10541) Tweaks for gather (#10532) Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517) Add conda support to nightly flake test (#10523) Rename datascience to datascience_modules (#10525) Clean up the extension activation code. (#10455) Allow escape and ctrl+U to clear the interactive window (#10513) Fix builtins so they don't interfere with our execution (#10511) Jupyter autocompletion will only show up on empty lines, (#10420) notify on missing kernel and interpreter with kernel (#10508)
5 participants
For #10280