Skip to content

Conversation

DavidKutu
Copy link

For #10023

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@DavidKutu DavidKutu added the no-changelog No news entry required label Mar 12, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented Mar 12, 2020

Codecov Report

Merging #10531 into release-2020.03 will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.03   #10531      +/-   ##
===================================================
- Coverage            60.86%   60.83%   -0.04%     
===================================================
  Files                  579      579              
  Lines                31290    31296       +6     
  Branches              4449     4449              
===================================================
- Hits                 19045    19039       -6     
- Misses               11282    11292      +10     
- Partials               963      965       +2     
Impacted Files Coverage Δ
...active-common/intellisense/intellisenseProvider.ts 37.09% <0.00%> (-0.74%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2603a...3974390. Read the comment docs.

@DavidKutu DavidKutu merged commit 6eab2fe into release-2020.03 Mar 12, 2020
@DavidKutu DavidKutu deleted the davidkutu/portIntellisenseFix branch March 12, 2020 01:47
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants