Skip to content

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Apr 13, 2020

For #10464, #10465

Change icon spacing and font for toolbar

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication


.native-editor-celltoolbar-middle .image-button {
margin-right: 8px;
margin-right: 3px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I prefer margin: 4px 3px.


.toolbar-menu-bar .image-button {
margin-right: 12px;
margin-top: 8px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or margin: 8px 7px 9px 7px

@codecov-io
Copy link

codecov-io commented Apr 13, 2020

Codecov Report

Merging #11130 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11130      +/-   ##
==========================================
- Coverage   61.47%   61.44%   -0.03%     
==========================================
  Files         597      597              
  Lines       32801    32801              
  Branches     4640     4640              
==========================================
- Hits        20163    20154       -9     
- Misses      11622    11629       +7     
- Partials     1016     1018       +2     
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
...ence/ipywidgets/localWidgetScriptSourceProvider.ts 88.13% <0.00%> (-3.39%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56051b8...3c70d67. Read the comment docs.

@rchiodo rchiodo merged commit 3a29293 into master Apr 13, 2020
@rchiodo rchiodo deleted the rchiodo/icon_spacing branch April 13, 2020 19:11
rchiodo added a commit that referenced this pull request Apr 13, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants