Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
([#11334](https://github.com/Microsoft/vscode-python/issues/11334))
1. Change "python.dataScience.runStartupCommands" commands to be a global setting, not a workspace setting.
([#11352](https://github.com/Microsoft/vscode-python/issues/11352))
1. Closing the interactive window shuts down other active notebook sessions.
([#11404](https://github.com/Microsoft/vscode-python/issues/11404))

### Thanks

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,13 @@ export class NotebookProvider implements INotebookProvider {
}

Array.from(this.notebooks.values()).forEach((promise) => {
promise.then((notebook) => notebook.dispose()).catch(noop);
promise
.then((notebook) => {
if (notebook.identity.scheme === 'history') {
notebook.dispose().ignoreErrors();
}
})
.catch(noop);
});

this.notebooks.clear();
Expand Down