Manually send didConfigurationChange on interpreter change #12366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11083
The PR for #11083 worked, but was incomplete in that there was no mechanism by which the extension could notify an LS that the interpreter had changed and that its view of pythonPath needs to be updated. When pythonPath changes in the actual
settings.json
file, VS Code knows how to send configuration changes to the right parties, and we get that for free.For now, manually trigger a
didChangeConfiguration
notification to ask the LS to check the settings again.Unfortunately, this notification provides no way to indicate which scope has changed, so must indiscriminately notify all. This may be optimized in the future with a custom protocol to manage pythonPath changes with LSs.
Has a news entry file (remember to thank yourself!).Appropriate comments and documentation strings in the code.Has sufficient logging.Has telemetry for enhancements.Unit tests & system/integration tests are added/updated.Test plan is updated as appropriate.package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).The wiki is updated with any design decisions/details.