Skip to content

Changed default save name when exporting from interactive window #12815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 8, 2020
Merged

Changed default save name when exporting from interactive window #12815

merged 5 commits into from
Jul 8, 2020

Conversation

techwithtim
Copy link

Previously when exporting from the interactive window the default exported file name would be blank. This makes the default exported file name the same as the python file that was used to generate the interactive window.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@techwithtim techwithtim added the no-changelog No news entry required label Jul 8, 2020
@techwithtim techwithtim self-assigned this Jul 8, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@techwithtim techwithtim merged commit 6bd129a into microsoft:master Jul 8, 2020
@techwithtim techwithtim deleted the defaultname branch July 8, 2020 22:11
DonJayamanne pushed a commit that referenced this pull request Jul 10, 2020
@techwithtim @DonJayamanne
Changed default save name when exporting from interactive window (#12815
ea0643c 
)

* changed default export file name from interactice window

* fixed naming issue

* refactor

* fixed tests

* hopefully fixed test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchiodo rchiodo rchiodo approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

Assignees

@techwithtim techwithtim

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@techwithtim @rchiodo