Skip to content

Add trust feature for VS Code Notebooks #12818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 10, 2020
Merged

Add trust feature for VS Code Notebooks #12818

merged 12 commits into from
Jul 10, 2020

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Jul 8, 2020 •
edited
Loading

For #10496

  • Adds support for trusted notebooks

Please review after ignoring white space

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Jul 8, 2020
DonJayamanne
DonJayamanne commented Jul 8, 2020
View reviewed changes
rchiodo
rchiodo reviewed Jul 8, 2020
View reviewed changes
DonJayamanne
DonJayamanne commented Jul 9, 2020
View reviewed changes
@DonJayamanne DonJayamanne requested a review from rchiodo July 9, 2020 00:01
@DonJayamanne DonJayamanne force-pushed the trustnb branch 2 times, most recently from 786e29b to 984dde3 Compare July 9, 2020 20:52
@DonJayamanne DonJayamanne marked this pull request as ready for review July 9, 2020 22:28
@DonJayamanne DonJayamanne changed the title Enable/disable notebook based on trust Add trust feature for VS Code Notebooks Jul 9, 2020
joyceerhl
joyceerhl reviewed Jul 9, 2020
View reviewed changes
rchiodo
rchiodo approved these changes Jul 10, 2020
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DonJayamanne DonJayamanne merged commit aba1d20 into microsoft:master Jul 10, 2020
@DonJayamanne DonJayamanne deleted the trustnb branch July 10, 2020 18:05
DonJayamanne added a commit that referenced this pull request Jul 10, 2020
@DonJayamanne
Add trust feature for VS Code Notebooks (#12818)
b1eb6f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

@greazer greazer Awaiting requested review from greazer

@techwithtim techwithtim Awaiting requested review from techwithtim

+2 more reviewers

@joyceerhl joyceerhl joyceerhl left review comments

@DavidKutu DavidKutu DavidKutu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DonJayamanne @IanMatthewHuff @rchiodo @DavidKutu @joyceerhl