Fixes to exporting of notebook to html #12882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
changed the title
DonJayamanne
commented
Jul 10, 2020
| const fileName = path.basename(target.fsPath, path.extname(target.fsPath)); | ||
| const tempDir = await this.exportUtil.generateTempDir(); | ||
| const sourceFilePath = await this.exportUtil.makeFileInDirectory(model, fileName, tempDir.path); | ||
| const sourceFilePath = await this.exportUtil.makeFileInDirectory(model, `${fileName}.ipynb`, tempDir.path); |
DonJayamanne
commented
Jul 10, 2020
| : `${path.basename(source.fsPath, path.extname(source.fsPath))}${extension}`; | ||
|
|
||
| const dialogUri = Uri.file(path.join(this.getLastFileSaveLocation().fsPath, notebookFileName)); | ||
| const dialogUri = Uri.file(path.join(this.getLastFileSaveLocation().fsPath, targetFileName)); |
There was a problem hiding this comment.
We were looking for *.htm when the *.html file was created.
E.g. target = abc.htm, then the file created is abc.htm.html.
DonJayamanne
commented
Jul 10, 2020
| const content = model ? model.getContent() : ''; | ||
| await this.fileSystem.writeFile(newFilePath, content, 'utf-8'); | ||
| } catch (e) { | ||
| await this.errorHandler.handleError(e); |
There was a problem hiding this comment.
This error handler was not rqeuired
DonJayamanne
commented
Jul 10, 2020
| const newFilePath = path.join(dirPath, fileName); | ||
|
|
||
| try { | ||
| const content = model ? model.getContent() : ''; |
There was a problem hiding this comment.
model cannot be undefined.
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
requested review from
DavidKutu,
IanMatthewHuff,
joyceerhl,
rchiodo and
techwithtim
DavidKutu
approved these changes
Jul 10, 2020
techwithtim
approved these changes
Jul 10, 2020
rchiodo
approved these changes
Jul 10, 2020
DonJayamanne
added a commit
that referenced
this pull request
Jul 10, 2020
Ensure we have file extensions for the source ipynb Ensure we have file extensions for the target html/pdf files Misc cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #12868