Skip to content

Gray out the bottom "insert cell below" button for untrusted notebooks #12905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2020
Merged

Gray out the bottom "insert cell below" button for untrusted notebooks #12905

merged 1 commit into from
Jul 13, 2020

Conversation

joyceerhl
Copy link

@joyceerhl joyceerhl commented Jul 12, 2020 •
edited
Loading

For #12865

Also ensures that the cursor is not a pointer when the button is disabled

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@joyceerhl joyceerhl added the no-changelog No news entry required label Jul 12, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joyceerhl joyceerhl requested review from a team, DavidKutu, DonJayamanne, IanMatthewHuff and rchiodo and removed request for a team July 12, 2020 04:00
@joyceerhl joyceerhl merged commit 9d05058 into microsoft:master Jul 13, 2020
DonJayamanne pushed a commit that referenced this pull request Jul 13, 2020
@joyceerhl @DonJayamanne
Disable AddCellLine if notebook is untrusted (#12905)
5b7eb61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

@rchiodo rchiodo Awaiting requested review from rchiodo

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joyceerhl @DonJayamanne