Skip to content

Conversation

karthiknadig
Copy link
Member

No description provided.

joyceerhl and others added 18 commits July 8, 2020 19:06
* fix a color on collapse all (microsoft#12895)

* update changelog
Co-authored-by: Timothy Ruscica <35348871+techwithtim@users.noreply.github.com>
Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
* Fix regressions in trusted notebooks (microsoft#12902)

* Handle trustAllNotebooks selection

* Fix bug where after trusting, UI didn't update

* Recover from ENOENT due to missing parent directory when trusting notebook (microsoft#12913)

* Disable keydown on native cells in untrusted notebooks (microsoft#12914)
…12942) (microsoft#12956)

* Check for hideFromUser before activating current terminal

* Add tests

* Tweak logic
* Only allow Enter / NumpadEnter w/o ctrl/shift/alt (microsoft#12939)

* Send telemetry for notebook trust prompt selections (microsoft#12964)

* Fixes for persisting trust (microsoft#12950)
) (microsoft#12975)

Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
…#12983)

* Update version and change log

* Improve detection when LS is fully loaded for IntelliCode (microsoft#12853)

* Fix path

* Actually fix settings

* Add news

* Add test

* Format

* Suppress 'jediEnabled' removal

* Drop survey first launch threshold

* Wait for client ready

* Handle async dispose

* Fix the date

Co-authored-by: Mikhail Arkhipov <mikhaila@microsoft.com>
* Ensure languageServer value is valid, send event during activate (microsoft#13064)

* Update change log and version

* Activate banner prompt for Pylance (microsoft#12817)

* Fix path

* Actually fix settings

* Add news

* Add test

* Format

* Suppress 'jediEnabled' removal

* Drop survey first launch threshold

* Remove LS experiments

* Frequency + tests

* Fix test

* Update message to match spec

* Open workspace for extension rather than changing setting

* Fix localization string

* Show banners asynchronously

* Add experiments

* Formatting

* Typo

* Put back verifyAll

* Remove obsolete experiments, add Pylance

* Suppress experiment if Pylance is installed

* PR feedback

Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>

* Update change log as per comments

Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Co-authored-by: Mikhail Arkhipov <mikhaila@microsoft.com>
* Fix the gather survey (microsoft#13086)

* fix the gather survey
added 'gather stats' telemetry
mention the gather comments to update the python ext

* oops

* fix tests and address comments

* update gather stats when resetting the kernel

* set globalstate vars to 0 when we open vs code

* fix gather stats telemetry

* fix tests

* fix tests for real
@karthiknadig karthiknadig added the no-changelog No news entry required label Jul 30, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

Merging #13204 into master will increase coverage by 0.50%.
The diff coverage is 64.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13204      +/-   ##
==========================================
+ Coverage   59.64%   60.14%   +0.50%     
==========================================
  Files         670      672       +2     
  Lines       36830    36606     -224     
  Branches     5188     5139      -49     
==========================================
+ Hits        21968    22018      +50     
+ Misses      13770    13490     -280     
- Partials     1092     1098       +6     
Impacted Files Coverage Δ
src/client/activation/node/languageServerProxy.ts 26.58% <0.00%> (ø)
...lient/common/application/applicationEnvironment.ts 18.18% <0.00%> (ø)
src/client/common/application/types.ts 100.00% <ø> (ø)
src/client/common/startPage/startPage.ts 31.87% <0.00%> (+0.66%) ⬆️
.../client/datascience/context/activeEditorContext.ts 14.63% <0.00%> (ø)
src/client/datascience/export/exportManager.ts 18.60% <0.00%> (ø)
...tascience/export/exportManagerDependencyChecker.ts 30.00% <0.00%> (ø)
src/client/datascience/export/types.ts 100.00% <ø> (ø)
...ient/datascience/interactive-ipynb/nativeEditor.ts 11.11% <0.00%> (+2.75%) ⬆️
...ascience/interactive-ipynb/nativeEditorProvider.ts 15.20% <0.00%> (ø)
... and 151 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0cf27d...890caec. Read the comment docs.

@karthiknadig karthiknadig merged commit cdf55e9 into microsoft:master Aug 5, 2020
@karthiknadig karthiknadig deleted the mergeback branch August 13, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants