Draft for discussion only: Code selection for run selection in terminal #14445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for discussion purposes only. We want to update the logic used for code selection, for code that is sent to the terminal. This will be done in two parts:
In this draft you can see the changes made to how we extract the text. This is needed to handle corner cases where de-denting does not work if we don't provide the full text. This code is used in DS Code Watcher
vscode-python/src/client/datascience/editor-integration/codewatcher.ts
Line 253 in 7e62824