Use sendTelemetryErrorEvent, preserve properties but redact errors #14453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heejaechang
reviewed
Oct 20, 2020
Codecov Report
@@ Coverage Diff @@
## main #14453 +/- ##
=======================================
Coverage 59.19% 59.19%
=======================================
Files 720 720
Lines 40211 40213 +2
Branches 5829 5829
=======================================
+ Hits 23802 23804 +2
Misses 15147 15147
Partials 1262 1262
Continue to review full report at Codecov.
|
heejaechang
approved these changes
Oct 20, 2020
jakebailey
requested review from
MikhailArkhipov,
karthiknadig and
kimadeline
kimadeline
reviewed
Oct 20, 2020
kimadeline
approved these changes
Oct 20, 2020
jakebailey
commented
Oct 26, 2020
jakebailey
force-pushed
the
use-error-event
branch
from
64bf018 to
9ec32d9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jakebailey
added a commit
to jakebailey/vscode-python
that referenced
this pull request
Oct 26, 2020
jakebailey
added a commit
to jakebailey/vscode-python
that referenced
this pull request
Oct 26, 2020
karthiknadig
pushed a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sendTelemetryExceptionAPI seems to send the errors nowhere we can access. But we can revert tosendTelemetryErrorEventand specify exactly which properties come from the error to obtain the same redaction behavior: https://github.com/Microsoft/vscode-extension-telemetry#sending-errors-as-eventsHas a news entry file (remember to thank yourself!).Appropriate comments and documentation strings in the code.Has sufficient logging.Unit tests & system/integration tests are added/updated.Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).The wiki is updated with any design decisions/details.