-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Put debugger data viewer integration behind an experiment #14460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## release-2020.10 #14460 +/- ##
===================================================
- Coverage 59.19% 59.17% -0.03%
===================================================
Files 720 721 +1
Lines 40211 40228 +17
Branches 5828 5828
===================================================
+ Hits 23802 23803 +1
- Misses 15147 15160 +13
- Partials 1262 1265 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for the October release? Because the myNoDS PR is going to trash these changes when it hits.
@IanMatthewHuff yeah this is for October. Maybe this should be going straight into the release branch then, since I'm going to rework the integration for November? |
I think that might be the smart approach to take, good thought on going directly to release. Otherwise this will just cause merge issues for the myNoDS change. |
Kudos, SonarCloud Quality Gate passed!
|
@DonJayamanne I believe I've addressed your comment on this PR! |
@joyceerhl we need the Compiler fix in master. Insiders is currently not getting pushed out because of it. |
@karthiknadig Will port it over, thanks! |
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).