Skip to content

Ask debug adapter for raw strings #14501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Ask debug adapter for raw strings #14501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/client/datascience/jupyter/debuggerVariables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export class DebuggerVariables extends DebugLocationTracker
return results
? {
...targetVariable,
...JSON.parse(results.result.slice(1, -1))
...JSON.parse(results.result)
}
: targetVariable;
}
Expand Down Expand Up @@ -158,7 +158,7 @@ export class DebuggerVariables extends DebugLocationTracker
// tslint:disable-next-line: no-any
(targetVariable as any).frameId
);
const chunkResults = JSON.parse(results.result.slice(1, -1));
const chunkResults = JSON.parse(results.result);
if (output && output.data) {
output = {
...output,
Expand Down Expand Up @@ -225,7 +225,8 @@ export class DebuggerVariables extends DebugLocationTracker
const results = await this.debugService.activeDebugSession.customRequest('evaluate', {
expression: code,
frameId: this.topMostFrameId || frameId,
context: 'repl'
context: 'repl',
format: { rawString: true }
});
if (results && results.result !== 'None') {
return results;
Expand Down Expand Up @@ -268,7 +269,7 @@ export class DebuggerVariables extends DebugLocationTracker
return {
...variable,
truncated: false,
...JSON.parse(results.result.slice(1, -1))
...JSON.parse(results.result)
};
} else {
// If no results, just return current value. Better than nothing.
Expand Down