Skip to content

Conversation

joyceerhl
Copy link

@joyceerhl joyceerhl commented Oct 27, 2020

For https://github.com/microsoft/vscode-python/issues/14535

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@joyceerhl joyceerhl added the no-changelog No news entry required label Oct 27, 2020
@codecov-io
Copy link

codecov-io commented Oct 27, 2020

Codecov Report

Merging #14543 into release-2020.10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-2020.10   #14543   +/-   ##
================================================
  Coverage            59.19%   59.19%           
================================================
  Files                  721      721           
  Lines                40230    40230           
  Branches              5828     5828           
================================================
  Hits                 23813    23813           
  Misses               15155    15155           
  Partials              1262     1262           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd5759...b5ef26d. Read the comment docs.

@joyceerhl joyceerhl changed the title Use globalThis Don't call acquireVsCodeApi more than once Oct 27, 2020
@joyceerhl joyceerhl marked this pull request as ready for review October 27, 2020 20:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rchiodo rchiodo merged commit 3e137f2 into release-2020.10 Oct 27, 2020
@rchiodo rchiodo deleted the fix-acquireVSCodeApi branch October 27, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants