Skip to content

Show Python: Launch TensorBoard command in command palette #15382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 11, 2021
Merged

Show Python: Launch TensorBoard command in command palette #15382

merged 4 commits into from
Feb 11, 2021

Conversation

joyceerhl
Copy link

Slight change of plans for release: we'll always show the command but keep all entrypoints behind a feature flag.

@joyceerhl joyceerhl added the no-changelog No news entry required label Feb 11, 2021
@codecov-io
Copy link

Codecov Report

Merging #15382 (8d08bab) into main (e04b43c) will increase coverage by 0%.
The diff coverage is 25%.

@@          Coverage Diff           @@
##            main   #15382   +/-   ##
======================================
  Coverage     65%      65%           
======================================
  Files        559      560    +1     
  Lines      26826    26854   +28     
  Branches    3872     3877    +5     
======================================
+ Hits       17476    17497   +21     
- Misses      8630     8636    +6     
- Partials     720      721    +1
Impacted Files Coverage Δ
src/client/common/process/rawProcessApis.ts 9% <9%> (ø)
src/client/common/process/proc.ts 53% <28%> (+39%) ⬆️
...nEnvironments/discovery/locators/services/conda.ts 91% <60%> (-2%) ⬇️
src/client/tensorBoard/tensorBoardUsageTracker.ts 88% <60%> (-5%) ⬇️
.../pythonEnvironments/common/externalDependencies.ts 69% <71%> (+6%) ⬆️
.../pythonEnvironments/info/environmentInfoService.ts 88% <77%> (-4%) ⬇️
...t/common/variables/environmentVariablesProvider.ts 93% <91%> (+<1%) ⬆️
...client/pythonEnvironments/base/info/interpreter.ts 71% <100%> (ø)

@joyceerhl joyceerhl added the skip package*.json package.json and package-lock.json don't both need updating label Feb 11, 2021
@joyceerhl joyceerhl marked this pull request as ready for review February 11, 2021 18:05
@rchiodo
Copy link

rchiodo commented Feb 11, 2021

keep all entrypoints behind a feature flag

Not sure what this means. It looks like the palette command now works regardless of the experiment flag? Is that not an entrypoint?

@joyceerhl
Copy link
Author

@rchiodo yeah that's not clear, by 'entrypoints' I meant to refer to the codelens and prompt.

@joyceerhl joyceerhl merged commit d321567 into microsoft:main Feb 11, 2021
joyceerhl added a commit that referenced this pull request Feb 11, 2021
@joyceerhl
Show Python: Launch TensorBoard command in command palette (#15382) (#…
5553953 
…15386)

* Always register Launch TensorBoard command

* Put usage tracking behind experiment
karthiknadig added a commit that referenced this pull request Feb 18, 2021
@karthiknadig @rchiodo
@ericsnowcurrently @greazer @joyceerhl @kimadeline @jakebailey
Mergeback from release to main (#15450)
ee27e8f 
* Cherry pick fix for native notebook support into release branch (#15369)

* Fix problem with notebook apis not being used. (#15366)

* Update changelog

* Remove news file

* Add extraPaths support to JediLSP (#15365)

* Add extraPaths support

* Remove duplicate opt option

* Eslint cleanup

* Fix tests

* Ignore directories with the same name as python binaries (#15367)

* Ignore directories with the same name as pyhton binaries

* Use withFileTypes instead of lstat

* Correct pipenv activation provider when in discovery experiment (#15319)

* Correct pipenv activation provider when in discovery experiment

* Fix ESLint errors

* In PythonEnvsReducer.resolveEnv(), always fall back to the wrapped locator. (#15350)

fixes #15118

* Fix issue with missing interpreter info for some cases  (#15376)

* Use child process apis directly.

* Use raw API in process service

* Handle process cleanup

* Address sonar

* Refactor process service by pulling the raw process APIs out of the class

* Address comments

* Add reference to CVE-2020-16977 fixed in Oct 2020. (#15381)

* Fix CI failing with the number of constructor arguments error (#15347)

* Fix Command 'workbench.action.closeAllEditors' timed out failure on CI (#15322)

* Ensure environment variables provider can be created using standard classes (#15377)

* Ensure environment variables provider can be created using standard classes

* Fix unit tests

* Fix ESLint errors for environment variable provider (#15383)

* Fix problem with notebook apis not being used. (#15366)

* Show Python: Launch TensorBoard command in command palette (#15382) (#15386)

* Always register Launch TensorBoard command

* Put usage tracking behind experiment

* Cherry picks from main to release (#15421)

* Do not call activate the discovery component before registering all the classes (#15379)

* Do not attempt to activate discovery component before registering all the classes

* Add clarification comment

* Code reviews

* Skip windows store and shims paths when using known path locators (#15388)

* Skip windows store and shims paths when using known path locators

* Clean up and comments

* Tests

* Handle cases where envs variables might not be set

* Typo

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>

* Change "Pylance not installed" prompt to allow reverting to Jedi (#15420)

* Allow on suggestion refresh by default (#15430)

Co-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>

Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com>
Co-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: Eric Snow <eric.snow@microsoft.com>
Co-authored-by: Jim Griesmer <jimgries@microsoft.com>
Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
karthiknadig added a commit that referenced this pull request Mar 8, 2021
@karthiknadig @rchiodo
@ericsnowcurrently @greazer @joyceerhl @kimadeline @jakebailey
Merge back from release to main (#15575)
172b824 
* Cherry pick fix for native notebook support into release branch (#15369)

* Fix problem with notebook apis not being used. (#15366)

* Update changelog

* Remove news file

* Add extraPaths support to JediLSP (#15365)

* Add extraPaths support

* Remove duplicate opt option

* Eslint cleanup

* Fix tests

* Ignore directories with the same name as python binaries (#15367)

* Ignore directories with the same name as pyhton binaries

* Use withFileTypes instead of lstat

* Correct pipenv activation provider when in discovery experiment (#15319)

* Correct pipenv activation provider when in discovery experiment

* Fix ESLint errors

* In PythonEnvsReducer.resolveEnv(), always fall back to the wrapped locator. (#15350)

fixes #15118

* Fix issue with missing interpreter info for some cases  (#15376)

* Use child process apis directly.

* Use raw API in process service

* Handle process cleanup

* Address sonar

* Refactor process service by pulling the raw process APIs out of the class

* Address comments

* Add reference to CVE-2020-16977 fixed in Oct 2020. (#15381)

* Fix CI failing with the number of constructor arguments error (#15347)

* Fix Command 'workbench.action.closeAllEditors' timed out failure on CI (#15322)

* Ensure environment variables provider can be created using standard classes (#15377)

* Ensure environment variables provider can be created using standard classes

* Fix unit tests

* Fix ESLint errors for environment variable provider (#15383)

* Fix problem with notebook apis not being used. (#15366)

* Show Python: Launch TensorBoard command in command palette (#15382) (#15386)

* Always register Launch TensorBoard command

* Put usage tracking behind experiment

* Cherry picks from main to release (#15421)

* Do not call activate the discovery component before registering all the classes (#15379)

* Do not attempt to activate discovery component before registering all the classes

* Add clarification comment

* Code reviews

* Skip windows store and shims paths when using known path locators (#15388)

* Skip windows store and shims paths when using known path locators

* Clean up and comments

* Tests

* Handle cases where envs variables might not be set

* Typo

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>

* Change "Pylance not installed" prompt to allow reverting to Jedi (#15420)

* Allow on suggestion refresh by default (#15430)

Co-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>

* Release final (#15433)

* Version update

* Change log updates

* TPN update

* Ensure pyenv virtual envs are not skipped when in discovery experiment (#15451)

* Ensure pyenv virtual envs are not skipped

* Add news

* Clean up

* Address comments

* Register Jedi regardless of what language server is configured (#15452)

* Register Jedi regardless of what language server is configured

* News entry

* Only call component adapter behind the discovery experiment (#15459)

* Update version and change log for point release (#15463)

* Version update

* Update change log

* Update start-up telemetry for Jedi LSP (#15419) (#15571)

* Version and change log update for point release (#15572)

Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com>
Co-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: Eric Snow <eric.snow@microsoft.com>
Co-authored-by: Jim Griesmer <jimgries@microsoft.com>
Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchiodo rchiodo rchiodo approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

@kimadeline kimadeline Awaiting requested review from kimadeline

+1 more reviewer

@DavidKutu DavidKutu DavidKutu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karthiknadig karthiknadig

Labels

no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joyceerhl @codecov-io @rchiodo @DavidKutu @karthiknadig